aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <philmd@linaro.org>2023-10-04 14:00:19 +0200
committerMarkus Armbruster <armbru@redhat.com>2023-10-06 13:27:48 +0200
commit8b7b9c5c88a8886312d3b9bc5e3615d21df143b6 (patch)
tree9bcf23c9fb968ff5e86d0325722eec41aaa987a2
parentfcd9a353798d09a6fe39e720fb1a52ed32cad91d (diff)
downloadqemu-8b7b9c5c88a8886312d3b9bc5e3615d21df143b6.zip
qemu-8b7b9c5c88a8886312d3b9bc5e3615d21df143b6.tar.gz
qemu-8b7b9c5c88a8886312d3b9bc5e3615d21df143b6.tar.bz2
trace/control: Clean up global variable shadowing
Fix: trace/control.c:288:34: error: declaration shadows a variable in the global scope [-Werror,-Wshadow] void trace_opt_parse(const char *optarg) ^ /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/getopt.h:77:14: note: previous declaration is here extern char *optarg; /* getopt(3) external variables */ ^ Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-ID: <20231004120019.93101-17-philmd@linaro.org> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Signed-off-by: Markus Armbruster <armbru@redhat.com>
-rw-r--r--trace/control.c4
-rw-r--r--trace/control.h4
2 files changed, 4 insertions, 4 deletions
diff --git a/trace/control.c b/trace/control.c
index 1a48a7e..ef10782 100644
--- a/trace/control.c
+++ b/trace/control.c
@@ -285,10 +285,10 @@ bool trace_init_backends(void)
return true;
}
-void trace_opt_parse(const char *optarg)
+void trace_opt_parse(const char *optstr)
{
QemuOpts *opts = qemu_opts_parse_noisily(qemu_find_opts("trace"),
- optarg, true);
+ optstr, true);
if (!opts) {
exit(1);
}
diff --git a/trace/control.h b/trace/control.h
index dfd209e..6754bfe 100644
--- a/trace/control.h
+++ b/trace/control.h
@@ -197,11 +197,11 @@ extern QemuOptsList qemu_trace_opts;
/**
* trace_opt_parse:
- * @optarg: A string argument of --trace command line argument
+ * @optstr: A string argument of --trace command line argument
*
* Initialize tracing subsystem.
*/
-void trace_opt_parse(const char *optarg);
+void trace_opt_parse(const char *optstr);
/**
* trace_get_vcpu_event_count: