diff options
| author | Daniel Henrique Barboza <danielhb413@gmail.com> | 2022-06-21 14:34:34 -0300 |
|---|---|---|
| committer | Daniel Henrique Barboza <danielhb413@gmail.com> | 2022-07-06 10:22:37 -0300 |
| commit | 8a69bca77a417167b743b8077c91ee43c52709cf (patch) | |
| tree | 9acfa5e716700d8ed2857f7cd8db6a9302a4e6a7 | |
| parent | ca45948991c1d22b30197cc741799f2543d42c37 (diff) | |
| download | qemu-8a69bca77a417167b743b8077c91ee43c52709cf.zip qemu-8a69bca77a417167b743b8077c91ee43c52709cf.tar.gz qemu-8a69bca77a417167b743b8077c91ee43c52709cf.tar.bz2 | |
ppc/pnv: make pnv_chip_power8_pic_print_info() use chip8->phbs[]
It's inneficient to scroll all child objects when we have all PHBs
available in chip8->phbs[].
pnv_chip_power8_pic_print_info_child() ended up folded into
pic_print_info() for simplicity.
Reviewed-by: Frederic Barrat <fbarrat@linux.ibm.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20220621173436.165912-7-danielhb413@gmail.com>
| -rw-r--r-- | hw/ppc/pnv.c | 22 |
1 files changed, 8 insertions, 14 deletions
diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 74a6c88..d3f77c8 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -652,25 +652,19 @@ static ISABus *pnv_isa_create(PnvChip *chip, Error **errp) return PNV_CHIP_GET_CLASS(chip)->isa_create(chip, errp); } -static int pnv_chip_power8_pic_print_info_child(Object *child, void *opaque) -{ - Monitor *mon = opaque; - PnvPHB3 *phb3 = (PnvPHB3 *) object_dynamic_cast(child, TYPE_PNV_PHB3); - - if (phb3) { - pnv_phb3_msi_pic_print_info(&phb3->msis, mon); - ics_pic_print_info(&phb3->lsis, mon); - } - return 0; -} - static void pnv_chip_power8_pic_print_info(PnvChip *chip, Monitor *mon) { Pnv8Chip *chip8 = PNV8_CHIP(chip); + int i; ics_pic_print_info(&chip8->psi.ics, mon); - object_child_foreach(OBJECT(chip), - pnv_chip_power8_pic_print_info_child, mon); + + for (i = 0; i < chip8->num_phbs; i++) { + PnvPHB3 *phb3 = &chip8->phbs[i]; + + pnv_phb3_msi_pic_print_info(&phb3->msis, mon); + ics_pic_print_info(&phb3->lsis, mon); + } } static int pnv_chip_power9_pic_print_info_child(Object *child, void *opaque) |