diff options
| author | John Snow <jsnow@redhat.com> | 2024-06-26 19:22:27 -0400 |
|---|---|---|
| committer | John Snow <jsnow@redhat.com> | 2024-07-12 16:36:20 -0400 |
| commit | 84e327e8448eacef879a0f85d38d212b6f58ee4a (patch) | |
| tree | 773a24e81a4844d0c2b7278402bbf10d87e24388 | |
| parent | 4469bee2c529832d762af4a2f89468c926f02fe4 (diff) | |
| download | qemu-84e327e8448eacef879a0f85d38d212b6f58ee4a.zip qemu-84e327e8448eacef879a0f85d38d212b6f58ee4a.tar.gz qemu-84e327e8448eacef879a0f85d38d212b6f58ee4a.tar.bz2 | |
python: linter changes for pylint 3.x
New bleeding edge versions, new nits to iron out. This addresses the
'check-python-tox' optional GitLab test, while 'check-python-minreqs'
saw no regressions, since it's frozen on an older version of pylint.
Fixes:
qemu/machine/machine.py:345:52: E0606: Possibly using variable 'sock' before assignment (possibly-used-before-assignment)
qemu/utils/qemu_ga_client.py:168:4: R1711: Useless return at end of function or method (useless-return)
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-id: 20240626232230.408004-2-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
| -rw-r--r-- | python/qemu/machine/machine.py | 1 | ||||
| -rw-r--r-- | python/qemu/utils/qemu_ga_client.py | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py index f648f6a..ebb58d5 100644 --- a/python/qemu/machine/machine.py +++ b/python/qemu/machine/machine.py @@ -335,6 +335,7 @@ class QEMUMachine: def _pre_launch(self) -> None: if self._qmp_set: + sock = None if self._monitor_address is None: self._sock_pair = socket.socketpair() os.set_inheritable(self._sock_pair[0].fileno(), True) diff --git a/python/qemu/utils/qemu_ga_client.py b/python/qemu/utils/qemu_ga_client.py index 9a665e6..cf0fcf9 100644 --- a/python/qemu/utils/qemu_ga_client.py +++ b/python/qemu/utils/qemu_ga_client.py @@ -174,7 +174,7 @@ class QemuGuestAgentClient: # On error exception will raise except asyncio.TimeoutError: # On success command will timed out - return + pass def shutdown(self, mode: str = 'powerdown') -> None: if mode not in ['powerdown', 'halt', 'reboot']: |