diff options
| author | Daniel P. Berrangé <berrange@redhat.com> | 2025-02-28 10:27:33 +0000 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2025-03-06 08:10:04 +0100 |
| commit | 8188356a260ca0201c42d128d8fa86f40160b513 (patch) | |
| tree | 657cdde7e060753fd3dd95e08088f6869b4ecebe | |
| parent | 6c5a1467f8d0a9e840c8aa193bc110cc76ee80e8 (diff) | |
| download | qemu-8188356a260ca0201c42d128d8fa86f40160b513.zip qemu-8188356a260ca0201c42d128d8fa86f40160b513.tar.gz qemu-8188356a260ca0201c42d128d8fa86f40160b513.tar.bz2 | |
tests/functional: set 'qemu_bin' as an object level field
The 'qemu_bin' field is currently set on the class, despite being
accessed as if it were an object instance field with 'self.qemu_bin'.
This is no obvious need to have it as a class field, so move it into
the object instance.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <20250228102738.3064045-3-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
| -rw-r--r-- | docs/devel/testing/functional.rst | 2 | ||||
| -rw-r--r-- | tests/functional/qemu_test/testcase.py | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/docs/devel/testing/functional.rst b/docs/devel/testing/functional.rst index ecc7389..bcb5509 100644 --- a/docs/devel/testing/functional.rst +++ b/docs/devel/testing/functional.rst @@ -173,7 +173,7 @@ QEMU binary selection ^^^^^^^^^^^^^^^^^^^^^ The QEMU binary used for the ``self.vm`` QEMUMachine instance will -primarily depend on the value of the ``qemu_bin`` class attribute. +primarily depend on the value of the ``qemu_bin`` instance attribute. If it is not explicitly set by the test code, its default value will be the result the QEMU_TEST_QEMU_BINARY environment variable. diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py index 9d5611c..058bf27 100644 --- a/tests/functional/qemu_test/testcase.py +++ b/tests/functional/qemu_test/testcase.py @@ -33,7 +33,6 @@ from .uncompress import uncompress class QemuBaseTest(unittest.TestCase): - qemu_bin = os.getenv('QEMU_TEST_QEMU_BINARY') arch = None workdir = None @@ -193,6 +192,7 @@ class QemuBaseTest(unittest.TestCase): return True def setUp(self): + self.qemu_bin = os.getenv('QEMU_TEST_QEMU_BINARY') self.assertIsNotNone(self.qemu_bin, 'QEMU_TEST_QEMU_BINARY must be set') self.arch = self.qemu_bin.split('-')[-1] self.socketdir = None |