aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2024-04-25 14:49:40 +0200
committerKevin Wolf <kwolf@redhat.com>2024-07-02 18:12:30 +0200
commit7e1110664ecbc4826f3c978ccb06b6c1bce823e6 (patch)
tree0a2e05190acea8f2776329148b4aef8eb97441b9
parent2eb42a728d27a43fdcad5f37d3f65706ce6deba5 (diff)
downloadqemu-7e1110664ecbc4826f3c978ccb06b6c1bce823e6.zip
qemu-7e1110664ecbc4826f3c978ccb06b6c1bce823e6.tar.gz
qemu-7e1110664ecbc4826f3c978ccb06b6c1bce823e6.tar.bz2
iotests/270: Don't store data-file with json: prefix in image
We want to disable filename parsing for data files because it's too easy to abuse in malicious image files. Make the test ready for the change by passing the data file explicitly in command line options. Cc: qemu-stable@nongnu.org Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
-rwxr-xr-xtests/qemu-iotests/27014
1 files changed, 11 insertions, 3 deletions
diff --git a/tests/qemu-iotests/270 b/tests/qemu-iotests/270
index 7435234..c37b674 100755
--- a/tests/qemu-iotests/270
+++ b/tests/qemu-iotests/270
@@ -60,8 +60,16 @@ _make_test_img -o cluster_size=2M,data_file="$TEST_IMG.orig" \
# "write" 2G of data without using any space.
# (qemu-img create does not like it, though, because null-co does not
# support image creation.)
-$QEMU_IMG amend -o data_file="json:{'driver':'null-co',,'size':'4294967296'}" \
- "$TEST_IMG"
+test_img_with_null_data="json:{
+ 'driver': '$IMGFMT',
+ 'file': {
+ 'filename': '$TEST_IMG'
+ },
+ 'data-file': {
+ 'driver': 'null-co',
+ 'size':'4294967296'
+ }
+}"
# This gives us a range of:
# 2^31 - 512 + 768 - 1 = 2^31 + 255 > 2^31
@@ -74,7 +82,7 @@ $QEMU_IMG amend -o data_file="json:{'driver':'null-co',,'size':'4294967296'}" \
# on L2 boundaries, we need large L2 tables; hence the cluster size of
# 2 MB. (Anything from 256 kB should work, though, because then one L2
# table covers 8 GB.)
-$QEMU_IO -c "write 768 $((2 ** 31 - 512))" "$TEST_IMG" | _filter_qemu_io
+$QEMU_IO -c "write 768 $((2 ** 31 - 512))" "$test_img_with_null_data" | _filter_qemu_io
_check_test_img