diff options
| author | Alex Bennée <alex.bennee@linaro.org> | 2024-09-16 09:53:44 +0100 |
|---|---|---|
| committer | Alex Bennée <alex.bennee@linaro.org> | 2024-09-19 15:58:01 +0100 |
| commit | 7866b0f7217c3318f22e807aa427c0c487fc0e68 (patch) | |
| tree | caa17737c0e5e175b0e4d5ba2f8175e5de1b9dca | |
| parent | cf2a78cbbb463d5716da9805c8fc5758937924d8 (diff) | |
| download | qemu-7866b0f7217c3318f22e807aa427c0c487fc0e68.zip qemu-7866b0f7217c3318f22e807aa427c0c487fc0e68.tar.gz qemu-7866b0f7217c3318f22e807aa427c0c487fc0e68.tar.bz2 | |
deprecation: don't enable TCG plugins by default with TCI
The softmmu memory instrumentation test sees so many more accesses
than a normal translated host and its really not worth fixing up. Lets
deprecate this odd configuration and save on the CI cycles.
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240916085400.1046925-3-alex.bennee@linaro.org>
| -rwxr-xr-x | configure | 11 | ||||
| -rw-r--r-- | docs/about/deprecated.rst | 8 |
2 files changed, 17 insertions, 2 deletions
@@ -629,6 +629,9 @@ meson_option_parse() { exit 1 fi } +has_meson_option() { + test "${meson_options#*"$1"}" != "$meson_options" +} meson_add_machine_file() { if test "$cross_compile" = "yes"; then @@ -1048,8 +1051,12 @@ if test "$static" = "yes" ; then plugins="no" fi if test "$plugins" != "no" && test $host_bits -eq 64; then - plugins=yes - subdirs="$subdirs contrib/plugins" + if has_meson_option "-Dtcg_interpreter=true"; then + plugins="no" + else + plugins=yes + subdirs="$subdirs contrib/plugins" + fi fi cat > $TMPC << EOF diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 809b2b9..c0aa52d 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -196,6 +196,14 @@ benefits from having plenty of host memory it seems reasonable to encourage users to use 64 bit builds of QEMU for analysis work whatever targets they are instrumenting. +TCG Plugin support not enabled by default with TCI (since 9.2) +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +While the TCG interpreter can interpret the TCG ops used by plugins it +is going to be so much slower it wouldn't make sense for any serious +instrumentation. Due to implementation differences there will also be +anomalies in things like memory instrumentation. + System emulator CPUs -------------------- |