diff options
| author | Alex Bennée <alex.bennee@linaro.org> | 2025-03-04 22:24:22 +0000 |
|---|---|---|
| committer | Alex Bennée <alex.bennee@linaro.org> | 2025-03-10 10:30:01 +0000 |
| commit | 77f005f954ea3cd0a161618a9f6c3f9d874c5b58 (patch) | |
| tree | cecb7259aca6372f5249d00543ebfc94315986f8 | |
| parent | 0cee7cfc2495c2c7d108c38a9b07162af78553b1 (diff) | |
| download | qemu-77f005f954ea3cd0a161618a9f6c3f9d874c5b58.zip qemu-77f005f954ea3cd0a161618a9f6c3f9d874c5b58.tar.gz qemu-77f005f954ea3cd0a161618a9f6c3f9d874c5b58.tar.bz2 | |
tests/tcg: fix constraints in test-i386-adcox
Clang complains:
clang -O2 -m64 -mcx16 /home/alex/lsrc/qemu.git/tests/tcg/i386/test-i386-adcox.c -o test-i386-adcox -static
/home/alex/lsrc/qemu.git/tests/tcg/i386/test-i386-adcox.c:32:26: error: invalid input constraint '0' in asm
: "r" ((REG)-1), "0" (flags), "1" (out_adcx), "2" (out_adox));
^
/home/alex/lsrc/qemu.git/tests/tcg/i386/test-i386-adcox.c:57:26: error: invalid input constraint '0' in asm
: "r" ((REG)-1), "0" (flags), "1" (out_adcx), "2" (out_adox));
^
2 errors generated.
Pointing out a numbered input constraint can't point to a read/write
output [1]. Convert to a read-only input constraint to allow this.
[1] https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20101101/036036.html
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20250304222439.2035603-16-alex.bennee@linaro.org>
| -rw-r--r-- | tests/tcg/i386/test-i386-adcox.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/tcg/i386/test-i386-adcox.c b/tests/tcg/i386/test-i386-adcox.c index 16169ef..a717064 100644 --- a/tests/tcg/i386/test-i386-adcox.c +++ b/tests/tcg/i386/test-i386-adcox.c @@ -29,7 +29,7 @@ void test_adox_adcx(uint32_t in_c, uint32_t in_o, REG adcx_operand, REG adox_ope "adcx %3, %1;" "pushf; pop %0" : "+r" (flags), "+r" (out_adcx), "+r" (out_adox) - : "r" ((REG)-1), "0" (flags), "1" (out_adcx), "2" (out_adox)); + : "r" ((REG) - 1), "0" (flags), "1" (out_adcx), "2" (out_adox)); assert(out_adcx == in_c + adcx_operand - 1); assert(out_adox == in_o + adox_operand - 1); @@ -53,8 +53,8 @@ void test_adcx_adox(uint32_t in_c, uint32_t in_o, REG adcx_operand, REG adox_ope "adcx %3, %1;" "adox %3, %2;" "pushf; pop %0" - : "+r" (flags), "+r" (out_adcx), "+r" (out_adox) - : "r" ((REG)-1), "0" (flags), "1" (out_adcx), "2" (out_adox)); + : "+r"(flags), "+r"(out_adcx), "+r"(out_adox) + : "r" ((REG)-1)); assert(out_adcx == in_c + adcx_operand - 1); assert(out_adox == in_o + adox_operand - 1); |