aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <philmd@redhat.com>2022-08-19 16:39:27 +0100
committerPeter Maydell <peter.maydell@linaro.org>2022-09-22 16:38:28 +0100
commit7650c8fe520c67c3b36f6962c4ad990f56ad40b8 (patch)
tree1e8fceae7f953f303ea6e676f24892651b246531
parenta580fdcd609e1db77ef5a1cbcbfd2af5ca05c939 (diff)
downloadqemu-7650c8fe520c67c3b36f6962c4ad990f56ad40b8.zip
qemu-7650c8fe520c67c3b36f6962c4ad990f56ad40b8.tar.gz
qemu-7650c8fe520c67c3b36f6962c4ad990f56ad40b8.tar.bz2
hw/intc/xics: Avoid dynamic stack allocation
Use autofree heap allocation instead of variable-length array on the stack. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Acked-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Greg Kurz <groug@kaod.org> Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Message-id: 20220819153931.3147384-8-peter.maydell@linaro.org
-rw-r--r--hw/intc/xics.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/intc/xics.c b/hw/intc/xics.c
index 5b0b4d9..dcd021a 100644
--- a/hw/intc/xics.c
+++ b/hw/intc/xics.c
@@ -567,8 +567,8 @@ static void ics_reset_irq(ICSIRQState *irq)
static void ics_reset(DeviceState *dev)
{
ICSState *ics = ICS(dev);
+ g_autofree uint8_t *flags = g_malloc(ics->nr_irqs);
int i;
- uint8_t flags[ics->nr_irqs];
for (i = 0; i < ics->nr_irqs; i++) {
flags[i] = ics->irqs[i].flags;