diff options
| author | Daniel P. Berrangé <berrange@redhat.com> | 2025-07-15 15:30:18 +0100 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2025-07-21 07:58:57 +0200 |
| commit | 72bc0134b500d599f0f1c253c78c68df642d1634 (patch) | |
| tree | 04b487532e93417befeec37442026cc86a5fb85d | |
| parent | 069a2ce8a75c9b59a4d08d6d2da3b36bfc5af3f4 (diff) | |
| download | qemu-72bc0134b500d599f0f1c253c78c68df642d1634.zip qemu-72bc0134b500d599f0f1c253c78c68df642d1634.tar.gz qemu-72bc0134b500d599f0f1c253c78c68df642d1634.tar.bz2 | |
functional: ensure sockets and files are closed
The multiprocess and virtio_gpu tests open sockets but then forget
to close them, which triggers resource leak warnings
The virtio_gpu test also fails to close a log file it opens.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20250715143023.1851000-10-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
| -rwxr-xr-x | tests/functional/test_multiprocess.py | 3 | ||||
| -rwxr-xr-x | tests/functional/test_virtio_gpu.py | 2 |
2 files changed, 5 insertions, 0 deletions
diff --git a/tests/functional/test_multiprocess.py b/tests/functional/test_multiprocess.py index 751cf10..92d5207 100755 --- a/tests/functional/test_multiprocess.py +++ b/tests/functional/test_multiprocess.py @@ -83,6 +83,9 @@ class Multiprocess(QemuSystemTest): 'cat /sys/bus/pci/devices/*/uevent', 'PCI_ID=1000:0012') + proxy_sock.close() + remote_sock.close() + def test_multiprocess(self): kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE if self.arch == 'x86_64': diff --git a/tests/functional/test_virtio_gpu.py b/tests/functional/test_virtio_gpu.py index 81c9156..be96de2 100755 --- a/tests/functional/test_virtio_gpu.py +++ b/tests/functional/test_virtio_gpu.py @@ -108,6 +108,7 @@ class VirtioGPUx86(QemuSystemTest): shell=False, close_fds=False, ) + self._vug_log_file.close() self.vm.set_console() self.vm.add_args("-cpu", "host") @@ -135,6 +136,7 @@ class VirtioGPUx86(QemuSystemTest): "features: +virgl +edid") self.vm.shutdown() qemu_sock.close() + vug_sock.close() vugp.terminate() vugp.wait() |