aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorlyx634449800 <yuxue.liu@jaguarmicro.com>2024-04-08 10:00:03 +0800
committerMichael S. Tsirkin <mst@redhat.com>2024-04-09 02:31:27 -0400
commit6ae72f609a21cfc56bf655cd4bcded5d07691ce7 (patch)
tree1fa41b0fd5a506966ad0b9a9b5f5c8a0362b1705
parent2d9a31b3c27311eca1682cb2c076d7a300441960 (diff)
downloadqemu-6ae72f609a21cfc56bf655cd4bcded5d07691ce7.zip
qemu-6ae72f609a21cfc56bf655cd4bcded5d07691ce7.tar.gz
qemu-6ae72f609a21cfc56bf655cd4bcded5d07691ce7.tar.bz2
vdpa-dev: Fix the issue of device status not updating when configuration interruption is triggered
The set_config callback function vhost_vdpa_device_get_config in vdpa-dev does not fetch the current device status from the hardware device, causing the guest os to not receive the latest device status information. The hardware updates the config status of the vdpa device and then notifies the os. The guest os receives an interrupt notification, triggering a get_config access in the kernel, which then enters qemu internally. Ultimately, the vhost_vdpa_device_get_config function of vdpa-dev is called One scenario encountered is when the device needs to bring down the vdpa net device. After modifying the status field of virtio_net_config in the hardware, it sends an interrupt notification. However, the guest os always receives the STATUS field as VIRTIO_NET_S_LINK_UP. Signed-off-by: Yuxue Liu <yuxue.liu@jaguarmicro.com> Acked-by: Jason Wang <jasowang@redhat.com> Message-Id: <20240408020003.1979-1-yuxue.liu@jaguarmicro.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
-rw-r--r--hw/virtio/vdpa-dev.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/hw/virtio/vdpa-dev.c b/hw/virtio/vdpa-dev.c
index 13e87f0..64b96b226c 100644
--- a/hw/virtio/vdpa-dev.c
+++ b/hw/virtio/vdpa-dev.c
@@ -195,7 +195,14 @@ static void
vhost_vdpa_device_get_config(VirtIODevice *vdev, uint8_t *config)
{
VhostVdpaDevice *s = VHOST_VDPA_DEVICE(vdev);
+ int ret;
+ ret = vhost_dev_get_config(&s->dev, s->config, s->config_size,
+ NULL);
+ if (ret < 0) {
+ error_report("get device config space failed");
+ return;
+ }
memcpy(config, s->config, s->config_size);
}