aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2020-01-22 03:02:43 -0500
committerMichael S. Tsirkin <mst@redhat.com>2020-02-25 08:23:18 -0500
commit6ab425d8a10226098c29971f74b5fa954d5498d6 (patch)
treeee803e271423754582569ee8464571147208b212
parent34b1429ca92eae5bb2a532d5596f6150ea17150a (diff)
downloadqemu-6ab425d8a10226098c29971f74b5fa954d5498d6.zip
qemu-6ab425d8a10226098c29971f74b5fa954d5498d6.tar.gz
qemu-6ab425d8a10226098c29971f74b5fa954d5498d6.tar.bz2
rebuild-expected-aml.sh: remind about the process
Remind users of rebuild-expected-aml.sh about the process to follow. Suppress the warning if allowed file list exists - that's a big hint user is already aware of the process. Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
-rwxr-xr-xtests/data/acpi/rebuild-expected-aml.sh7
1 files changed, 7 insertions, 0 deletions
diff --git a/tests/data/acpi/rebuild-expected-aml.sh b/tests/data/acpi/rebuild-expected-aml.sh
index d44e511..9cbaab1 100755
--- a/tests/data/acpi/rebuild-expected-aml.sh
+++ b/tests/data/acpi/rebuild-expected-aml.sh
@@ -31,6 +31,13 @@ done
eval `grep SRC_PATH= config-host.mak`
+old_allowed_dif=`grep -v -e 'List of comma-separated changed AML files to ignore' ${SRC_PATH}/tests/qtest/bios-tables-test-allowed-diff.h`
+
echo '/* List of comma-separated changed AML files to ignore */' > ${SRC_PATH}/tests/qtest/bios-tables-test-allowed-diff.h
echo "The files were rebuilt and can be added to git."
+
+if [ -z "$old_allowed_dif" ]; then
+ echo "Note! Please do not commit expected files with source changes"
+ echo "Note! Please follow the process documented in ${SRC_PATH}/tests/qtest/bios-tables-test.c"
+fi