diff options
| author | Daniel P. Berrange <berrange@redhat.com> | 2017-08-29 17:04:52 +0100 |
|---|---|---|
| committer | Daniel P. Berrange <berrange@redhat.com> | 2017-09-05 13:21:58 +0100 |
| commit | 689ed13e73bdb5a5ca3366524475e3065fae854a (patch) | |
| tree | 6f91badc14972dfacad1a83ab8db2f081e8e3bba | |
| parent | d4622e55883211072621958d39ddaa73483d201e (diff) | |
| download | qemu-689ed13e73bdb5a5ca3366524475e3065fae854a.zip qemu-689ed13e73bdb5a5ca3366524475e3065fae854a.tar.gz qemu-689ed13e73bdb5a5ca3366524475e3065fae854a.tar.bz2 | |
io: fix check for handshake completion in TLS test
The TLS I/O channel test had mistakenly used && instead
of || when checking for handshake completion. As a
result it could terminate the handshake process before
it had actually completed. This was harmless before but
changes in GNUTLS 3.6.0 exposed this bug and caused the
test suite to fail.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
| -rw-r--r-- | tests/test-io-channel-tls.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/test-io-channel-tls.c b/tests/test-io-channel-tls.c index ff96877..a210d01 100644 --- a/tests/test-io-channel-tls.c +++ b/tests/test-io-channel-tls.c @@ -218,7 +218,7 @@ static void test_io_channel_tls(const void *opaque) mainloop = g_main_context_default(); do { g_main_context_iteration(mainloop, TRUE); - } while (!clientHandshake.finished && + } while (!clientHandshake.finished || !serverHandshake.finished); g_assert(clientHandshake.failed == data->expectClientFail); |