diff options
| author | Bibo Mao <maobibo@loongson.cn> | 2024-06-12 11:36:37 +0800 |
|---|---|---|
| committer | Song Gao <gaosong@loongson.cn> | 2024-07-12 09:41:18 +0800 |
| commit | 5efbc384c6dee9f4960e5ef05be84af370cef6bb (patch) | |
| tree | ebb471ce0d7531078f44557b7ce7142656460ac2 | |
| parent | 0aca736433dcb56f365fe8a18ed1b969ca247304 (diff) | |
| download | qemu-5efbc384c6dee9f4960e5ef05be84af370cef6bb.zip qemu-5efbc384c6dee9f4960e5ef05be84af370cef6bb.tar.gz qemu-5efbc384c6dee9f4960e5ef05be84af370cef6bb.tar.bz2 | |
hw/loongarch/virt: Remove unused assignment
There is abuse usage about local variable gap. Remove
duplicated assignment and solve Coverity reported error.
Resolves: Coverity CID 1546441
Fixes: 3cc451cbce ("hw/loongarch: Refine fwcfg memory map")
Signed-off-by: Bibo Mao <maobibo@loongson.cn>
Reviewed-by: Song Gao <gaosong@loongson.cn>
Message-Id: <20240612033637.167787-1-maobibo@loongson.cn>
Signed-off-by: Song Gao <gaosong@loongson.cn>
| -rw-r--r-- | hw/loongarch/virt.c | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index 8be2d2f..e592b1b 100644 --- a/hw/loongarch/virt.c +++ b/hw/loongarch/virt.c @@ -1054,7 +1054,6 @@ static void fw_cfg_add_memory(MachineState *ms) memmap_add_entry(base, gap, 1); size -= gap; base = VIRT_HIGHMEM_BASE; - gap = ram_size - VIRT_LOWMEM_SIZE; } if (size) { @@ -1067,17 +1066,17 @@ static void fw_cfg_add_memory(MachineState *ms) } /* add fw_cfg memory map of other nodes */ - size = ram_size - numa_info[0].node_mem; - gap = VIRT_LOWMEM_BASE + VIRT_LOWMEM_SIZE; - if (base < gap && (base + size) > gap) { + if (numa_info[0].node_mem < gap && ram_size > gap) { /* * memory map for the maining nodes splited into two part - * lowram: [base, +(gap - base)) - * highram: [VIRT_HIGHMEM_BASE, +(size - (gap - base))) + * lowram: [base, +(gap - numa_info[0].node_mem)) + * highram: [VIRT_HIGHMEM_BASE, +(ram_size - gap)) */ - memmap_add_entry(base, gap - base, 1); - size -= gap - base; + memmap_add_entry(base, gap - numa_info[0].node_mem, 1); + size = ram_size - gap; base = VIRT_HIGHMEM_BASE; + } else { + size = ram_size - numa_info[0].node_mem; } if (size) |