diff options
| author | Matheus Tavares Bernardino <matheus.bernardino@oss.qualcomm.com> | 2025-05-26 10:20:55 -0700 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2025-05-30 09:52:08 +0200 |
| commit | 5c54a367265ec19ed94a535cd15d178c16b8cae0 (patch) | |
| tree | cb371c82c2d9fd3690a1ec5dea676ffbe8a319d6 | |
| parent | c4eb3f10a3573392c297f2124a81af9041300ddd (diff) | |
| download | qemu-5c54a367265ec19ed94a535cd15d178c16b8cae0.zip qemu-5c54a367265ec19ed94a535cd15d178c16b8cae0.tar.gz qemu-5c54a367265ec19ed94a535cd15d178c16b8cae0.tar.bz2 | |
tests/unit/test-util-sockets: fix mem-leak on error object
The test fails with --enable-asan as the error struct is never freed.
In the case where the test expects a success but it fails, let's also
report the error for debugging (it will be freed internally).
Fixes 316e8ee8d6 ("util/qemu-sockets: Refactor inet_parse() to use QemuOpts")
Signed-off-by: Matheus Tavares Bernardino <matheus.bernardino@oss.qualcomm.com>
Reviewed-by: Juraj Marcin <jmarcin@redhat.com>
Message-ID: <518d94c7db20060b2a086cf55ee9bffab992a907.1748280011.git.matheus.bernardino@oss.qualcomm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
| -rw-r--r-- | tests/unit/test-util-sockets.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/tests/unit/test-util-sockets.c b/tests/unit/test-util-sockets.c index 8492f4d..ee66d72 100644 --- a/tests/unit/test-util-sockets.c +++ b/tests/unit/test-util-sockets.c @@ -341,8 +341,12 @@ static void inet_parse_test_helper(const char *str, int rc = inet_parse(&addr, str, &error); if (success) { + if (error) { + error_report_err(error); + } g_assert_cmpint(rc, ==, 0); } else { + error_free(error); g_assert_cmpint(rc, <, 0); } if (exp_addr != NULL) { |