diff options
| author | Fabiano Rosas <farosas@suse.de> | 2024-08-27 14:45:55 -0300 |
|---|---|---|
| committer | Fabiano Rosas <farosas@suse.de> | 2024-09-03 16:24:35 -0300 |
| commit | 5aff71767c7c695fce2975a6bc020b23d173cdcd (patch) | |
| tree | 5398bcd9fee0846b79b003090fe1f66711f827d9 | |
| parent | 9f0e10890109601f375b687736b65e8fac734b55 (diff) | |
| download | qemu-5aff71767c7c695fce2975a6bc020b23d173cdcd.zip qemu-5aff71767c7c695fce2975a6bc020b23d173cdcd.tar.gz qemu-5aff71767c7c695fce2975a6bc020b23d173cdcd.tar.bz2 | |
migration/multifd: Move pages accounting into multifd_send_zero_page_detect()
All references to pages are being removed from the multifd worker
threads in order to allow multifd to deal with different payload
types.
multifd_send_zero_page_detect() is called by all multifd migration
paths that deal with pages and is the last spot where zero pages and
normal page amounts are adjusted. Move the pages accounting into that
function.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
| -rw-r--r-- | migration/multifd-zero-page.c | 7 | ||||
| -rw-r--r-- | migration/multifd.c | 2 |
2 files changed, 6 insertions, 3 deletions
diff --git a/migration/multifd-zero-page.c b/migration/multifd-zero-page.c index 6506a4a..f1e988a 100644 --- a/migration/multifd-zero-page.c +++ b/migration/multifd-zero-page.c @@ -14,6 +14,7 @@ #include "qemu/cutils.h" #include "exec/ramblock.h" #include "migration.h" +#include "migration-stats.h" #include "multifd.h" #include "options.h" #include "ram.h" @@ -53,7 +54,7 @@ void multifd_send_zero_page_detect(MultiFDSendParams *p) if (!multifd_zero_page_enabled()) { pages->normal_num = pages->num; - return; + goto out; } /* @@ -74,6 +75,10 @@ void multifd_send_zero_page_detect(MultiFDSendParams *p) } pages->normal_num = i; + +out: + stat64_add(&mig_stats.normal_pages, pages->normal_num); + stat64_add(&mig_stats.zero_pages, pages->num - pages->normal_num); } void multifd_recv_zero_page_process(MultiFDRecvParams *p) diff --git a/migration/multifd.c b/migration/multifd.c index c310d28..410b7e1 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -989,8 +989,6 @@ static void *multifd_send_thread(void *opaque) stat64_add(&mig_stats.multifd_bytes, p->next_packet_size + p->packet_len); - stat64_add(&mig_stats.normal_pages, pages->normal_num); - stat64_add(&mig_stats.zero_pages, pages->num - pages->normal_num); multifd_pages_reset(pages); p->next_packet_size = 0; |