diff options
| author | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2025-01-15 13:50:22 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2025-01-15 13:06:54 -0500 |
| commit | 4ffedca347c458db17c464f9329222403fe54f22 (patch) | |
| tree | a114e33423428f5e8654aa5dbfbf5d38697e9ebc | |
| parent | 5eb07a4ff067053b4d6bf55d2d614b65b00a476b (diff) | |
| download | qemu-4ffedca347c458db17c464f9329222403fe54f22.zip qemu-4ffedca347c458db17c464f9329222403fe54f22.tar.gz qemu-4ffedca347c458db17c464f9329222403fe54f22.tar.bz2 | |
acpi/ghes: Remove a duplicated out of bounds check
acpi_ghes_record_errors() has an assert() at the beginning
to ensure that source_id will be lower than
ACPI_GHES_ERROR_SOURCE_COUNT. Remove a duplicated check.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <df33b004d85b7b9aa388fb2ac530dcdea94b7edc.1736945236.git.mchehab+huawei@kernel.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
| -rw-r--r-- | hw/acpi/ghes.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c index 29cd7e4..5f67322 100644 --- a/hw/acpi/ghes.c +++ b/hw/acpi/ghes.c @@ -404,9 +404,7 @@ int acpi_ghes_record_errors(uint8_t source_id, uint64_t physical_address) return -1; } - if (source_id < ACPI_GHES_ERROR_SOURCE_COUNT) { - start_addr += source_id * sizeof(uint64_t); - } + start_addr += source_id * sizeof(uint64_t); cpu_physical_memory_read(start_addr, &error_block_addr, sizeof(error_block_addr)); |