diff options
| author | David Hildenbrand <david@redhat.com> | 2024-04-16 16:14:26 +0200 |
|---|---|---|
| committer | David Hildenbrand <david@redhat.com> | 2024-07-10 18:06:24 +0200 |
| commit | 4d13ae45ff93fa825ceb39dfd16b305f4baccd18 (patch) | |
| tree | 6643cd405cc10b1e166d5e84e48d85b2fe4d2b2e | |
| parent | 59084feb256c617063e0dbe7e64821ae8852d7cf (diff) | |
| download | qemu-4d13ae45ff93fa825ceb39dfd16b305f4baccd18.zip qemu-4d13ae45ff93fa825ceb39dfd16b305f4baccd18.tar.gz qemu-4d13ae45ff93fa825ceb39dfd16b305f4baccd18.tar.bz2 | |
virtio-mem: improve error message when unplug of device fails due to plugged memory
The error message is actually expressive, considering QEMU only. But
when called from Libvirt, talking about "size" can be confusing, because
in Libvirt "size" translates to the memory backend size in QEMU (maximum
size) and "current" translates to the QEMU "size" property.
Let's simply avoid talking about the "size" property and spell out that
some device memory is still plugged.
Message-ID: <20240416141426.588544-1-david@redhat.com>
Tested-by: Mario Casquero <mcasquer@redhat.com>
Cc: Liang Cong <lcong@redhat.com>
Cc: Mario Casquero <mcasquer@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
| -rw-r--r-- | hw/virtio/virtio-mem.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c index ffd119e..ef64bf1 100644 --- a/hw/virtio/virtio-mem.c +++ b/hw/virtio/virtio-mem.c @@ -1832,8 +1832,8 @@ static void virtio_mem_unplug_request_check(VirtIOMEM *vmem, Error **errp) } if (vmem->size) { - error_setg(errp, "virtio-mem device cannot get unplugged while" - " '" VIRTIO_MEM_SIZE_PROP "' != '0'"); + error_setg(errp, "virtio-mem device cannot get unplugged while some" + " of its memory is still plugged"); return; } if (vmem->requested_size) { |