aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoel Stanley <joel@jms.id.au>2025-06-04 12:24:40 +0930
committerAlistair Francis <alistair.francis@wdc.com>2025-07-04 21:09:49 +1000
commit4b7b4f9cb4fd4b569661e690c593780332d7291a (patch)
tree12767b1a69401ff488cbf1d190295456b781f16f
parent349500bfb8523c94f88da4bfc41a22ccbba19055 (diff)
downloadqemu-4b7b4f9cb4fd4b569661e690c593780332d7291a.zip
qemu-4b7b4f9cb4fd4b569661e690c593780332d7291a.tar.gz
qemu-4b7b4f9cb4fd4b569661e690c593780332d7291a.tar.bz2
hw/riscv/virt: Use setprop_sized_cells for aplic
The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Signed-off-by: Joel Stanley <joel@jms.id.au> Message-ID: <20250604025450.85327-5-joel@jms.id.au> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
-rw-r--r--hw/riscv/virt.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index e074a29..205fa6e 100644
--- a/hw/riscv/virt.c
+++ b/hw/riscv/virt.c
@@ -655,8 +655,8 @@ static void create_fdt_one_aplic(RISCVVirtState *s, int socket,
qemu_fdt_setprop_cell(ms->fdt, aplic_name, "msi-parent", msi_phandle);
}
- qemu_fdt_setprop_cells(ms->fdt, aplic_name, "reg",
- 0x0, aplic_addr, 0x0, aplic_size);
+ qemu_fdt_setprop_sized_cells(ms->fdt, aplic_name, "reg",
+ 2, aplic_addr, 2, aplic_size);
qemu_fdt_setprop_cell(ms->fdt, aplic_name, "riscv,num-sources",
VIRT_IRQCHIP_NUM_SOURCES);