diff options
| author | Philippe Mathieu-Daudé <f4bug@amsat.org> | 2020-09-04 15:14:01 +0200 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2020-09-10 16:20:49 +0200 |
| commit | 4a4a604cc60cb94525fc4c2d1230557c1e7d166d (patch) | |
| tree | 6493952ee6fff410770d56137d30bdc3e64299c5 | |
| parent | c857f9050cff9eb02ff05e901152dc1570f798bd (diff) | |
| download | qemu-4a4a604cc60cb94525fc4c2d1230557c1e7d166d.zip qemu-4a4a604cc60cb94525fc4c2d1230557c1e7d166d.tar.gz qemu-4a4a604cc60cb94525fc4c2d1230557c1e7d166d.tar.bz2 | |
hw/net/e1000e: Remove overwritten read handler for STATUS register
The STATUS register readop handler is initialized first with
the generic e1000e_mac_readreg() handler:
2861 #define e1000e_getreg(x) [x] = e1000e_mac_readreg
2862 typedef uint32_t (*readops)(E1000ECore *, int);
2863 static const readops e1000e_macreg_readops[] = {
....
2919 e1000e_getreg(STATUS),
Then overwritten with the specific e1000e_get_status handler:
3018 [STATUS] = e1000e_get_status,
To avoid confusion, remove the overwritten initialization.
6f3fbe4ed0 ("net: Introduce e1000e device emulation")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Message-Id: <20200904131402.590055-2-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
| -rw-r--r-- | hw/net/e1000e_core.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index bcd186c..5170e6a 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -2916,7 +2916,6 @@ static const readops e1000e_macreg_readops[] = { e1000e_getreg(TSYNCRXCTL), e1000e_getreg(TDH), e1000e_getreg(LEDCTL), - e1000e_getreg(STATUS), e1000e_getreg(TCTL), e1000e_getreg(TDBAL), e1000e_getreg(TDLEN), |