aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarc-André Lureau <marcandre.lureau@redhat.com>2023-09-11 18:04:47 +0400
committerMarc-André Lureau <marcandre.lureau@redhat.com>2023-09-12 11:13:52 +0400
commit48a35e12faf90a896c5aa4755812201e00d60316 (patch)
tree733a0bc1834c033ea906dd56e12fa528749e02d8
parent04562ee88e99d71f4e6017f64123f726dd8b41e1 (diff)
downloadqemu-48a35e12faf90a896c5aa4755812201e00d60316.zip
qemu-48a35e12faf90a896c5aa4755812201e00d60316.tar.gz
qemu-48a35e12faf90a896c5aa4755812201e00d60316.tar.bz2
ui: fix crash when there are no active_console
Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. 0x0000555555888630 in dpy_ui_info_supported (con=0x0) at ../ui/console.c:812 812 return con->hw_ops->ui_info != NULL; (gdb) bt #0 0x0000555555888630 in dpy_ui_info_supported (con=0x0) at ../ui/console.c:812 #1 0x00005555558a44b1 in protocol_client_msg (vs=0x5555578c76c0, data=0x5555581e93f0 <incomplete sequence \373>, len=24) at ../ui/vnc.c:2585 #2 0x00005555558a19ac in vnc_client_read (vs=0x5555578c76c0) at ../ui/vnc.c:1607 #3 0x00005555558a1ac2 in vnc_client_io (ioc=0x5555581eb0e0, condition=G_IO_IN, opaque=0x5555578c76c0) at ../ui/vnc.c:1635 Fixes: https://issues.redhat.com/browse/RHEL-2600 Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Albert Esteve <aesteve@redhat.com>
-rw-r--r--ui/console.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/ui/console.c b/ui/console.c
index da341f0..aa1e094 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -806,6 +806,9 @@ bool dpy_ui_info_supported(QemuConsole *con)
if (con == NULL) {
con = active_console;
}
+ if (con == NULL) {
+ return false;
+ }
return con->hw_ops->ui_info != NULL;
}