aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2023-04-25 08:42:23 +0200
committerMarkus Armbruster <armbru@redhat.com>2023-04-28 11:48:34 +0200
commit4622c70689f0bc39bd31922cee2a569f2bc3f390 (patch)
treea5fc3cfb1b0b07b04bfe044ce1a34c9e510ab39c
parent94546de1a811cabc0c878ed474ef51b7ec102b84 (diff)
downloadqemu-4622c70689f0bc39bd31922cee2a569f2bc3f390.zip
qemu-4622c70689f0bc39bd31922cee2a569f2bc3f390.tar.gz
qemu-4622c70689f0bc39bd31922cee2a569f2bc3f390.tar.bz2
qapi storage-daemon/qapi: Fix documentation section structure
In the QEMU QMP Reference Manual, subsection "Block core (VM unrelated)" is empty. Its contents is at the end of subsection "Background jobs" instead. That's because qapi/job.json is included first from qapi/block-core.json, which makes qapi/job.json's documentation go between qapi/block-core.json's subsection heading and contents. In the QEMU Storage Daemon QMP Reference Manual, section "Block Devices" contains nothing but an empty subsection "Block core (VM unrelated)". The latter's contents is at the end section "Socket data types", along with subsection "Block device exports". Subsection "Background jobs" is at the end of section "Cryptography". All this is because storage-daemon/qapi/qapi-schema.json includes modules in a confused order. Fix both as follows. Turn subsection "Background jobs" into a section. Move it before section "Block devices" in the QEMU QMP Reference Manual, by including qapi/jobs.json right before qapi/block.json. Reorder include directives in storage-daemon/qapi/qapi-schema.json to match the order in qapi/qapi-schema.json, so that the QEMU Storage Daemon QMP Reference Manual's section structure the QEMU QMP Reference Manual's. In the QEMU QMP Reference Manual, qapi/cryptodev.json's documentation is at the end of section "Virtio devices". That's because it lacks a section heading, and therefore gets squashed into whatever section happens to precede it. Add section heading so it's in section "Cryptography devices". Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Acked-by: zhenwei pi <pizhenwei@bytedance.com> Message-Id: <20230425064223.820979-17-armbru@redhat.com>
-rw-r--r--qapi/cryptodev.json4
-rw-r--r--qapi/job.json2
-rw-r--r--qapi/qapi-schema.json2
-rw-r--r--storage-daemon/qapi/qapi-schema.json20
4 files changed, 20 insertions, 8 deletions
diff --git a/qapi/cryptodev.json b/qapi/cryptodev.json
index f33f96a..cf960ea 100644
--- a/qapi/cryptodev.json
+++ b/qapi/cryptodev.json
@@ -5,6 +5,10 @@
# See the COPYING file in the top-level directory.
##
+# = Cryptography devices
+##
+
+##
# @QCryptodevBackendAlgType:
#
# The supported algorithm types of a crypto device.
diff --git a/qapi/job.json b/qapi/job.json
index bc41047..9e29a79 100644
--- a/qapi/job.json
+++ b/qapi/job.json
@@ -2,7 +2,7 @@
# vim: filetype=python
##
-# == Background jobs
+# = Background jobs
##
##
diff --git a/qapi/qapi-schema.json b/qapi/qapi-schema.json
index e57d8ff..bb7217d 100644
--- a/qapi/qapi-schema.json
+++ b/qapi/qapi-schema.json
@@ -43,11 +43,11 @@
{ 'include': 'sockets.json' }
{ 'include': 'run-state.json' }
{ 'include': 'crypto.json' }
+{ 'include': 'job.json' }
{ 'include': 'block.json' }
{ 'include': 'block-export.json' }
{ 'include': 'char.json' }
{ 'include': 'dump.json' }
-{ 'include': 'job.json' }
{ 'include': 'net.json' }
{ 'include': 'rdma.json' }
{ 'include': 'rocker.json' }
diff --git a/storage-daemon/qapi/qapi-schema.json b/storage-daemon/qapi/qapi-schema.json
index 67749d1..f10c949 100644
--- a/storage-daemon/qapi/qapi-schema.json
+++ b/storage-daemon/qapi/qapi-schema.json
@@ -15,18 +15,26 @@
{ 'include': '../../qapi/pragma.json' }
+# Documentation generated with qapi-gen.py is in source order, with
+# included sub-schemas inserted at the first include directive
+# (subsequent include directives have no effect). To get a sane and
+# stable order, it's best to include each sub-schema just once, or
+# include it first right here.
+
+{ 'include': '../../qapi/common.json' }
+{ 'include': '../../qapi/sockets.json' }
+{ 'include': '../../qapi/crypto.json' }
+{ 'include': '../../qapi/job.json' }
+
##
# = Block devices
##
{ 'include': '../../qapi/block-core.json' }
{ 'include': '../../qapi/block-export.json' }
+
{ 'include': '../../qapi/char.json' }
-{ 'include': '../../qapi/common.json' }
+{ 'include': '../../qapi/authz.json' }
+{ 'include': '../../qapi/transaction.json' }
{ 'include': '../../qapi/control.json' }
-{ 'include': '../../qapi/crypto.json' }
{ 'include': '../../qapi/introspect.json' }
-{ 'include': '../../qapi/job.json' }
-{ 'include': '../../qapi/authz.json' }
{ 'include': '../../qapi/qom.json' }
-{ 'include': '../../qapi/sockets.json' }
-{ 'include': '../../qapi/transaction.json' }