diff options
| author | Laurent Vivier <lvivier@redhat.com> | 2016-10-17 12:30:20 +0200 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2016-10-28 09:36:58 +1100 |
| commit | 458f3b2c953bdc7110896cb3691251023652523f (patch) | |
| tree | f7a39aa379fa38f48af7bd663d43e7fb0dbf9640 | |
| parent | f62e0bbb39eec088ff4fbe6a7ec38af51fac5e94 (diff) | |
| download | qemu-458f3b2c953bdc7110896cb3691251023652523f.zip qemu-458f3b2c953bdc7110896cb3691251023652523f.tar.gz qemu-458f3b2c953bdc7110896cb3691251023652523f.tar.bz2 | |
tests: don't check if qtest_spapr_boot() returns NULL
qtest_spapr_boot()/qtest_pc_boot()/qtest_boot() call qtest_vboot()
and qtest_vboot() calls g_malloc(),
and g_malloc() never fails:
if memory allocation fails, the application is terminated.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
| -rw-r--r-- | tests/libqos/libqos.c | 2 | ||||
| -rw-r--r-- | tests/rtas-test.c | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/tests/libqos/libqos.c b/tests/libqos/libqos.c index 7abb482..6226546 100644 --- a/tests/libqos/libqos.c +++ b/tests/libqos/libqos.c @@ -10,6 +10,8 @@ /** * Launch QEMU with the given command line, * and then set up interrupts and our guest malloc interface. + * Never returns NULL: + * Terminates the application in case an error is encountered. */ QOSState *qtest_vboot(QOSOps *ops, const char *cmdline_fmt, va_list ap) { diff --git a/tests/rtas-test.c b/tests/rtas-test.c index ba0867a..276c87e 100644 --- a/tests/rtas-test.c +++ b/tests/rtas-test.c @@ -14,7 +14,6 @@ static void test_rtas_get_time_of_day(void) time_t t1, t2; qs = qtest_spapr_boot("-machine pseries"); - g_assert(qs != NULL); t1 = time(NULL); ret = qrtas_get_time_of_day(qs->alloc, &tm, &ns); |