diff options
| author | Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | 2021-08-24 11:38:33 +0300 |
|---|---|---|
| committer | Hanna Reitz <hreitz@redhat.com> | 2021-09-01 14:03:47 +0200 |
| commit | 451532311a6c37ac58794305c88307bd7c54526f (patch) | |
| tree | c796d6335d368f5951c0c6b0b29f7f637531fc39 | |
| parent | 3860c0201924d9f7f9b125b8bdda8a8627de4a08 (diff) | |
| download | qemu-451532311a6c37ac58794305c88307bd7c54526f.zip qemu-451532311a6c37ac58794305c88307bd7c54526f.tar.gz qemu-451532311a6c37ac58794305c88307bd7c54526f.tar.bz2 | |
block/copy-before-write: drop extra bdrv_unref on failure path
bdrv_attach_child() do bdrv_unref() on failure, so we shouldn't do it
by hand here.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20210824083856.17408-12-vsementsov@virtuozzo.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
| -rw-r--r-- | block/copy-before-write.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/block/copy-before-write.c b/block/copy-before-write.c index 2a51cc6..945d934 100644 --- a/block/copy-before-write.c +++ b/block/copy-before-write.c @@ -201,7 +201,6 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source, state->target = bdrv_attach_child(top, target, "target", &child_of_bds, BDRV_CHILD_DATA, errp); if (!state->target) { - bdrv_unref(target); bdrv_unref(top); return NULL; } |