diff options
| author | Eric Auger <eric.auger@redhat.com> | 2021-03-09 11:27:36 +0100 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2021-03-12 12:40:09 +0000 |
| commit | 41ce9a912641cd7f820bcfccea15e30efc32104e (patch) | |
| tree | 0fe35d1f36aee7f3e3f69cab99579ef17d353cb9 | |
| parent | a55b441b2ca578417ab3a7a62129cd801e22abf4 (diff) | |
| download | qemu-41ce9a912641cd7f820bcfccea15e30efc32104e.zip qemu-41ce9a912641cd7f820bcfccea15e30efc32104e.tar.gz qemu-41ce9a912641cd7f820bcfccea15e30efc32104e.tar.bz2 | |
intel_iommu: Fix mask may be uninitialized in vtd_context_device_invalidate
With -Werror=maybe-uninitialized configuration we get
../hw/i386/intel_iommu.c: In function ‘vtd_context_device_invalidate’:
../hw/i386/intel_iommu.c:1888:10: error: ‘mask’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
1888 | mask = ~mask;
| ~~~~~^~~~~~~
Add a g_assert_not_reached() to avoid the error.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20210309102742.30442-2-eric.auger@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
| -rw-r--r-- | hw/i386/intel_iommu.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index b4f5094..3206f37 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -1884,6 +1884,8 @@ static void vtd_context_device_invalidate(IntelIOMMUState *s, case 3: mask = 7; /* Mask bit 2:0 in the SID field */ break; + default: + g_assert_not_reached(); } mask = ~mask; |