diff options
| author | Emanuele Giuseppe Esposito <eesposit@redhat.com> | 2021-06-14 10:29:30 +0200 |
|---|---|---|
| committer | Max Reitz <mreitz@redhat.com> | 2021-07-19 17:38:38 +0200 |
| commit | 4153b553bd81e5b270b816699184df5d74c46805 (patch) | |
| tree | 92e46608302ce0e0fe6c45bf58ed6375c178a9c0 | |
| parent | 2196c341f7d0df161d412d3d7ea81545ab60ea2b (diff) | |
| download | qemu-4153b553bd81e5b270b816699184df5d74c46805.zip qemu-4153b553bd81e5b270b816699184df5d74c46805.tar.gz qemu-4153b553bd81e5b270b816699184df5d74c46805.tar.bz2 | |
block/blkdebug: remove new_state field and instead use a local variable
There seems to be no benefit in using a field. Replace it with a local
variable, and move the state update before the yields.
The state update has do be done before the yields because now using
a local variable does not allow the new updated state to be visible
by the other yields.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Message-Id: <20210614082931.24925-6-eesposit@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
| -rw-r--r-- | block/blkdebug.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/block/blkdebug.c b/block/blkdebug.c index dd82131..b47c3fd 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -40,7 +40,6 @@ typedef struct BDRVBlkdebugState { int state; - int new_state; uint64_t align; uint64_t max_transfer; uint64_t opt_write_zero; @@ -792,7 +791,7 @@ static void suspend_request(BlockDriverState *bs, BlkdebugRule *rule) } static void process_rule(BlockDriverState *bs, struct BlkdebugRule *rule, - int *action_count) + int *action_count, int *new_state) { BDRVBlkdebugState *s = bs->opaque; @@ -812,7 +811,7 @@ static void process_rule(BlockDriverState *bs, struct BlkdebugRule *rule, break; case ACTION_SET_STATE: - s->new_state = rule->options.set_state.new_state; + *new_state = rule->options.set_state.new_state; break; case ACTION_SUSPEND: @@ -825,21 +824,21 @@ static void blkdebug_debug_event(BlockDriverState *bs, BlkdebugEvent event) { BDRVBlkdebugState *s = bs->opaque; struct BlkdebugRule *rule, *next; + int new_state; int actions_count[ACTION__MAX] = { 0 }; assert((int)event >= 0 && event < BLKDBG__MAX); - s->new_state = s->state; + new_state = s->state; QLIST_FOREACH_SAFE(rule, &s->rules[event], next, next) { - process_rule(bs, rule, actions_count); + process_rule(bs, rule, actions_count, &new_state); } + s->state = new_state; while (actions_count[ACTION_SUSPEND] > 0) { qemu_coroutine_yield(); actions_count[ACTION_SUSPEND]--; } - - s->state = s->new_state; } static int blkdebug_debug_breakpoint(BlockDriverState *bs, const char *event, |