diff options
| author | Philippe Mathieu-Daudé <philmd@redhat.com> | 2021-09-03 12:05:51 +0200 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2024-05-08 19:11:34 +0200 |
| commit | 40fed8c1d3a2bcef81c8de3f55d7e1abe1397347 (patch) | |
| tree | 43236fae218e187984bdccd3814d24c3d5a61763 | |
| parent | f9cc8cfdf346cadc92db8fce32c8b5d7f1095163 (diff) | |
| download | qemu-40fed8c1d3a2bcef81c8de3f55d7e1abe1397347.zip qemu-40fed8c1d3a2bcef81c8de3f55d7e1abe1397347.tar.gz qemu-40fed8c1d3a2bcef81c8de3f55d7e1abe1397347.tar.bz2 | |
target/ppc: Replace g_memdup() by g_memdup2()
Per https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538
The old API took the size of the memory to duplicate as a guint,
whereas most memory functions take memory sizes as a gsize. This
made it easy to accidentally pass a gsize to g_memdup(). For large
values, that would lead to a silent truncation of the size from 64
to 32 bits, and result in a heap area being returned which is
significantly smaller than what the caller expects. This can likely
be exploited in various modules to cause a heap buffer overflow.
Replace g_memdup() by the safer g_memdup2() wrapper.
Trivially safe because the argument was directly from sizeof.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <20210903174510.751630-27-philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
| -rw-r--r-- | target/ppc/mmu-hash64.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/target/ppc/mmu-hash64.c b/target/ppc/mmu-hash64.c index 5a0d80f..0966422 100644 --- a/target/ppc/mmu-hash64.c +++ b/target/ppc/mmu-hash64.c @@ -1188,7 +1188,7 @@ void ppc_hash64_init(PowerPCCPU *cpu) return; } - cpu->hash64_opts = g_memdup(pcc->hash64_opts, sizeof(*cpu->hash64_opts)); + cpu->hash64_opts = g_memdup2(pcc->hash64_opts, sizeof(*cpu->hash64_opts)); } void ppc_hash64_finalize(PowerPCCPU *cpu) |