aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <philmd@linaro.org>2024-08-07 22:28:03 +0200
committerNicholas Piggin <npiggin@gmail.com>2024-11-04 09:09:13 +1000
commit3feabc18ad4d4bdc178a205b986353a54dbfcf20 (patch)
tree13779f8f5c7aa1779440134c1c0700f9e61884e8
parent65f53702d2e4bd045ce16ca874469cdd1e1ef4e4 (diff)
downloadqemu-3feabc18ad4d4bdc178a205b986353a54dbfcf20.zip
qemu-3feabc18ad4d4bdc178a205b986353a54dbfcf20.tar.gz
qemu-3feabc18ad4d4bdc178a205b986353a54dbfcf20.tar.bz2
hw/ssi/pnv_spi: Return early in transfer()
Return early to simplify next commit. No logical change intended. Cc: qemu-stable@nongnu.org Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
-rw-r--r--hw/ssi/pnv_spi.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/hw/ssi/pnv_spi.c b/hw/ssi/pnv_spi.c
index d15a597..72bcc00 100644
--- a/hw/ssi/pnv_spi.c
+++ b/hw/ssi/pnv_spi.c
@@ -217,6 +217,9 @@ static void transfer(PnvSpi *s, PnvXferBuffer *payload)
PnvXferBuffer *rsp_payload = NULL;
rsp_payload = pnv_spi_xfer_buffer_new();
+ if (!rsp_payload) {
+ return;
+ }
for (int offset = 0; offset < payload->len; offset += s->transfer_len) {
tx = 0;
for (int i = 0; i < s->transfer_len; i++) {
@@ -235,9 +238,7 @@ static void transfer(PnvSpi *s, PnvXferBuffer *payload)
(rx >> (8 * (s->transfer_len - 1) - i * 8)) & 0xFF;
}
}
- if (rsp_payload != NULL) {
- spi_response(s, s->N1_bits, rsp_payload);
- }
+ spi_response(s, s->N1_bits, rsp_payload);
}
static inline uint8_t get_seq_index(PnvSpi *s)