diff options
| author | Zide Chen <zide.chen@intel.com> | 2024-06-03 17:02:21 -0700 |
|---|---|---|
| committer | Michael Tokarev <mjt@tls.msk.ru> | 2024-06-30 19:51:44 +0300 |
| commit | 3fd73736c69b71035cf1154ef58e8fa494f8612c (patch) | |
| tree | e03c77c4ea71c9ada1f99ee9b68a26f4d46c5898 | |
| parent | 2b5d12b68514e3d81086a65fc8496822d5bd4359 (diff) | |
| download | qemu-3fd73736c69b71035cf1154ef58e8fa494f8612c.zip qemu-3fd73736c69b71035cf1154ef58e8fa494f8612c.tar.gz qemu-3fd73736c69b71035cf1154ef58e8fa494f8612c.tar.bz2 | |
vl: Allow multiple -overcommit commands
Both cpu-pm and mem-lock are related to system resource overcommit, but
they are separate from each other, in terms of how they are realized,
and of course, they are applied to different system resources.
It's tempting to use separate command lines to specify their behavior.
e.g., in the following example, the cpu-pm command is quietly
overwritten, and it's not easy to notice it without careful inspection.
--overcommit mem-lock=on
--overcommit cpu-pm=on
Fixes: c8c9dc42b7ca ("Remove the deprecated -realtime option")
Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Zide Chen <zide.chen@intel.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
| -rw-r--r-- | system/vl.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/system/vl.c b/system/vl.c index cfcb674..4dc8626 100644 --- a/system/vl.c +++ b/system/vl.c @@ -3546,8 +3546,8 @@ void qemu_init(int argc, char **argv) if (!opts) { exit(1); } - enable_mlock = qemu_opt_get_bool(opts, "mem-lock", false); - enable_cpu_pm = qemu_opt_get_bool(opts, "cpu-pm", false); + enable_mlock = qemu_opt_get_bool(opts, "mem-lock", enable_mlock); + enable_cpu_pm = qemu_opt_get_bool(opts, "cpu-pm", enable_cpu_pm); break; case QEMU_OPTION_compat: { |