diff options
author | Marc-André Lureau <marcandre.lureau@redhat.com> | 2024-09-24 15:49:47 +0400 |
---|---|---|
committer | Marc-André Lureau <marcandre.lureau@redhat.com> | 2024-10-02 16:14:29 +0400 |
commit | 3cd804c565a7eb7804217fc67169b73c27671ab7 (patch) | |
tree | 097e95e173e931158f608d9a8b89fa3b270d4a99 | |
parent | 0d0f95c7bcde008510e6c9013e00b25941c83871 (diff) | |
download | qemu-3cd804c565a7eb7804217fc67169b73c27671ab7.zip qemu-3cd804c565a7eb7804217fc67169b73c27671ab7.tar.gz qemu-3cd804c565a7eb7804217fc67169b73c27671ab7.tar.bz2 |
target/loongarch: fix -Werror=maybe-uninitialized false-positive
../target/loongarch/gdbstub.c:55:20: error: ‘val’ may be used uninitialized [-Werror=maybe-uninitialized]
55 | return gdb_get_reg32(mem_buf, val);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../target/loongarch/gdbstub.c:39:18: note: ‘val’ was declared here
39 | uint64_t val;
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
-rw-r--r-- | target/loongarch/gdbstub.c | 26 |
1 files changed, 14 insertions, 12 deletions
diff --git a/target/loongarch/gdbstub.c b/target/loongarch/gdbstub.c index 7ca245e..3a03cf9 100644 --- a/target/loongarch/gdbstub.c +++ b/target/loongarch/gdbstub.c @@ -34,26 +34,28 @@ void write_fcc(CPULoongArchState *env, uint64_t val) int loongarch_cpu_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n) { CPULoongArchState *env = cpu_env(cs); - uint64_t val; - - if (0 <= n && n < 32) { - val = env->gpr[n]; - } else if (n == 32) { - /* orig_a0 */ - val = 0; - } else if (n == 33) { - val = env->pc; - } else if (n == 34) { - val = env->CSR_BADV; - } if (0 <= n && n <= 34) { + uint64_t val; + + if (n < 32) { + val = env->gpr[n]; + } else if (n == 32) { + /* orig_a0 */ + val = 0; + } else if (n == 33) { + val = env->pc; + } else /* if (n == 34) */ { + val = env->CSR_BADV; + } + if (is_la64(env)) { return gdb_get_reg64(mem_buf, val); } else { return gdb_get_reg32(mem_buf, val); } } + return 0; } |