diff options
| author | Philippe Mathieu-Daudé <philmd@linaro.org> | 2023-11-29 16:42:01 +0100 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2024-01-19 12:28:59 +0100 |
| commit | 396f66f99dfb405bd2a29582d043d2a6b7b37d6d (patch) | |
| tree | 96cc1363f9cedb316f0f4cca222d40096bdb5dab | |
| parent | b94b8c604b6d4e6071569c4c00a1f4c841028934 (diff) | |
| download | qemu-396f66f99dfb405bd2a29582d043d2a6b7b37d6d.zip qemu-396f66f99dfb405bd2a29582d043d2a6b7b37d6d.tar.gz qemu-396f66f99dfb405bd2a29582d043d2a6b7b37d6d.tar.bz2 | |
accel: Do not set CPUState::can_do_io in non-TCG accels
'can_do_io' is specific to TCG. It was added to other
accelerators in 626cf8f4c6 ("icount: set can_do_io outside
TB execution"), then likely copy/pasted in commit c97d6d2cdf
("i386: hvf: add code base from Google's QEMU repository").
Having it set in non-TCG code is confusing, so remove it from
QTest / HVF / KVM.
Fixes: 626cf8f4c6 ("icount: set can_do_io outside TB execution")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20231129205037.16849-1-philmd@linaro.org>
| -rw-r--r-- | accel/dummy-cpus.c | 1 | ||||
| -rw-r--r-- | accel/hvf/hvf-accel-ops.c | 1 | ||||
| -rw-r--r-- | accel/kvm/kvm-accel-ops.c | 1 |
3 files changed, 0 insertions, 3 deletions
diff --git a/accel/dummy-cpus.c b/accel/dummy-cpus.c index f4b0ec5..20519f1 100644 --- a/accel/dummy-cpus.c +++ b/accel/dummy-cpus.c @@ -27,7 +27,6 @@ static void *dummy_cpu_thread_fn(void *arg) bql_lock(); qemu_thread_get_self(cpu->thread); cpu->thread_id = qemu_get_thread_id(); - cpu->neg.can_do_io = true; current_cpu = cpu; #ifndef _WIN32 diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index 8eabb69..d94d41a 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -428,7 +428,6 @@ static void *hvf_cpu_thread_fn(void *arg) qemu_thread_get_self(cpu->thread); cpu->thread_id = qemu_get_thread_id(); - cpu->neg.can_do_io = true; current_cpu = cpu; hvf_init_vcpu(cpu); diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index 45ff06e..b3c946d 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -36,7 +36,6 @@ static void *kvm_vcpu_thread_fn(void *arg) bql_lock(); qemu_thread_get_self(cpu->thread); cpu->thread_id = qemu_get_thread_id(); - cpu->neg.can_do_io = true; current_cpu = cpu; r = kvm_init_vcpu(cpu, &error_fatal); |