diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2012-07-20 13:34:50 +0100 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2012-07-20 13:34:50 +0100 |
| commit | 3871481c0a3f64f25563a5a246c188acdc01ee49 (patch) | |
| tree | 9f58ada541a598459b540a172cd44528e586c5a2 | |
| parent | 0b94438480c8f52cc9e22b1038e6ba5096245c4e (diff) | |
| download | qemu-3871481c0a3f64f25563a5a246c188acdc01ee49.zip qemu-3871481c0a3f64f25563a5a246c188acdc01ee49.tar.gz qemu-3871481c0a3f64f25563a5a246c188acdc01ee49.tar.bz2 | |
hw/arm_boot.c: Check for RAM sizes exceeding ATAGS capacity
The legacy ATAGS format for passing information to the kernel only
allows RAM sizes which fit in 32 bits; enforce this restriction
rather than silently doing something weird.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
| -rw-r--r-- | hw/arm_boot.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/hw/arm_boot.c b/hw/arm_boot.c index 29ae324..af71ed6 100644 --- a/hw/arm_boot.c +++ b/hw/arm_boot.c @@ -399,6 +399,12 @@ void arm_load_kernel(ARMCPU *cpu, struct arm_boot_info *info) bootloader[5] = dtb_start; } else { bootloader[5] = info->loader_start + KERNEL_ARGS_ADDR; + if (info->ram_size >= (1ULL << 32)) { + fprintf(stderr, "qemu: RAM size must be less than 4GB to boot" + " Linux kernel using ATAGS (try passing a device tree" + " using -dtb)\n"); + exit(1); + } } bootloader[6] = entry; for (n = 0; n < sizeof(bootloader) / 4; n++) { |