aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2022-07-20 16:26:27 +0100
committerPeter Maydell <peter.maydell@linaro.org>2022-07-26 13:40:44 +0100
commit35a7a6fc5624b1df828d82f2dfa74d0e4188b3b2 (patch)
tree64e342d69ca8ab46590dff9d02722e15e660c374
parentfca75f60abbf2a7f88264977ff0bb3ff4285989c (diff)
downloadqemu-35a7a6fc5624b1df828d82f2dfa74d0e4188b3b2.zip
qemu-35a7a6fc5624b1df828d82f2dfa74d0e4188b3b2.tar.gz
qemu-35a7a6fc5624b1df828d82f2dfa74d0e4188b3b2.tar.bz2
configure: Add missing POSIX-required space
In commit 7d7dbf9dc15be6e1 we added a line to the configure script which is not valid POSIX shell syntax, because it is missing a space after a '!' character. shellcheck diagnoses this: if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then ^-- SC1035: You are missing a required space after the !. and the OpenBSD shell will not correctly handle this without the space. Fixes: 7d7dbf9dc15be6e1 ("configure: replace --enable/disable-git-update with --with-git-submodules") Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Thomas Huth <thuth@redhat.com> Tested-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Message-id: 20220720152631.450903-2-peter.maydell@linaro.org
-rwxr-xr-xconfigure2
1 files changed, 1 insertions, 1 deletions
diff --git a/configure b/configure
index 35e0b28..dec6f03 100755
--- a/configure
+++ b/configure
@@ -2425,7 +2425,7 @@ else
cxx=
fi
-if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then
+if ! (GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then
exit 1
fi