diff options
| author | Philippe Mathieu-Daudé <philmd@linaro.org> | 2025-02-19 16:23:13 +0100 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2025-03-04 14:45:34 +0100 |
| commit | 2e6b2e08756e618e5d4316ff277e78213942a2a0 (patch) | |
| tree | 64ebdb501c36ae3c55ff9bfcaff1b17061d2e217 | |
| parent | 3e0f118f8259dd5bcdf9caf3762f92718b97f47a (diff) | |
| download | qemu-2e6b2e08756e618e5d4316ff277e78213942a2a0.zip qemu-2e6b2e08756e618e5d4316ff277e78213942a2a0.tar.gz qemu-2e6b2e08756e618e5d4316ff277e78213942a2a0.tar.bz2 | |
hw/char/bcm2835_aux: Really use RX FIFO depth
While we model a 8-elements RX FIFO since the BCM2835 AUX model
was introduced in commit 97398d900ca ("bcm2835_aux: add emulation
of BCM2835 AUX block") we only read 1 char at a time!
Have the IOCanReadHandler handler return how many elements are
available, and use that in the IOReadHandler handler.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Luc Michel <luc.michel@amd.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20250220092903.3726-6-philmd@linaro.org>
| -rw-r--r-- | hw/char/bcm2835_aux.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/hw/char/bcm2835_aux.c b/hw/char/bcm2835_aux.c index 73ad593..c6e7ecc 100644 --- a/hw/char/bcm2835_aux.c +++ b/hw/char/bcm2835_aux.c @@ -221,7 +221,7 @@ static int bcm2835_aux_can_receive(void *opaque) { BCM2835AuxState *s = opaque; - return s->read_count < BCM2835_AUX_RX_FIFO_LEN; + return BCM2835_AUX_RX_FIFO_LEN - s->read_count; } static void bcm2835_aux_put_fifo(void *opaque, uint8_t value) @@ -243,7 +243,9 @@ static void bcm2835_aux_put_fifo(void *opaque, uint8_t value) static void bcm2835_aux_receive(void *opaque, const uint8_t *buf, int size) { - bcm2835_aux_put_fifo(opaque, *buf); + for (int i = 0; i < size; i++) { + bcm2835_aux_put_fifo(opaque, buf[i]); + } } static const MemoryRegionOps bcm2835_aux_ops = { |