aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMiroslav Rezanina <mrezanin@redhat.com>2021-05-05 03:59:03 -0400
committerKevin Wolf <kwolf@redhat.com>2021-06-29 16:51:00 +0200
commit2d369d6e6e890a0204183e853604f8077329c4bc (patch)
tree5e3a9ca887affcdf552be9c40f55481e9fe26b5c
parent13d5f87cc3b94bfccc501142df4a7b12fee3a6e7 (diff)
downloadqemu-2d369d6e6e890a0204183e853604f8077329c4bc.zip
qemu-2d369d6e6e890a0204183e853604f8077329c4bc.tar.gz
qemu-2d369d6e6e890a0204183e853604f8077329c4bc.tar.bz2
Prevent compiler warning on block.c
Commit 3108a15cf (block: introduce bdrv_drop_filter()) introduced uninitialized variable to_cow_parent in bdrv_replace_node_common function that is used only when detach_subchain is true. It is used in two places. First if block properly initialize the variable and second block use it. However, compiler may treat these two blocks as two independent cases so it thinks first block can fail test and second one pass (although both use same condition). This cause warning that variable can be uninitialized in second block. The warning was observed with GCC 8.4.1 and 11.0.1. To prevent this warning, initialize the variable with NULL. Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com> Message-Id: <1162368493.17178530.1620201543649.JavaMail.zimbra@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
-rw-r--r--block.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block.c b/block.c
index 1d37f13..3e27785 100644
--- a/block.c
+++ b/block.c
@@ -4866,7 +4866,7 @@ static int bdrv_replace_node_common(BlockDriverState *from,
Transaction *tran = tran_new();
g_autoptr(GHashTable) found = NULL;
g_autoptr(GSList) refresh_list = NULL;
- BlockDriverState *to_cow_parent;
+ BlockDriverState *to_cow_parent = NULL;
int ret;
if (detach_subchain) {