aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex Williamson <alex.williamson@redhat.com>2012-06-14 12:16:28 -0600
committerMichael S. Tsirkin <mst@robin.(none)>2012-06-18 10:21:11 +0300
commit2cf62ad74261a9bd90e5b720e726f0404640b16a (patch)
tree41b1325285ed45c13327c1b56bef848e922cad3f
parenteebcb0a76a7e8b093740c9bd3db00f5b38e79a33 (diff)
downloadqemu-2cf62ad74261a9bd90e5b720e726f0404640b16a.zip
qemu-2cf62ad74261a9bd90e5b720e726f0404640b16a.tar.gz
qemu-2cf62ad74261a9bd90e5b720e726f0404640b16a.tar.bz2
msix: Note endian TODO item
MSIX, like PCI, is little endian. Specifying native is wrong here, but we need to check the rest of the file to determine if it's as simple as flipping this macro. Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
-rw-r--r--hw/msix.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/hw/msix.c b/hw/msix.c
index 50885ac..87d316a 100644
--- a/hw/msix.c
+++ b/hw/msix.c
@@ -224,6 +224,7 @@ static void msix_mmio_write(void *opaque, target_phys_addr_t addr,
static const MemoryRegionOps msix_mmio_ops = {
.read = msix_mmio_read,
.write = msix_mmio_write,
+ /* TODO: MSIX should be LITTLE_ENDIAN. */
.endianness = DEVICE_NATIVE_ENDIAN,
.valid = {
.min_access_size = 4,