diff options
| author | Pavel Pisa <pisa@cmp.felk.cvut.cz> | 2024-01-04 00:14:26 +0100 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2024-01-05 16:20:15 +0100 |
| commit | 25145a7d7735344a469551946fc2a7f19eb4aa3d (patch) | |
| tree | f0590ad2ff0f405d65509df61956af8a13b60bdd | |
| parent | 5e077a77670d36975cc0dc885d2e9d9f67ab14c1 (diff) | |
| download | qemu-25145a7d7735344a469551946fc2a7f19eb4aa3d.zip qemu-25145a7d7735344a469551946fc2a7f19eb4aa3d.tar.gz qemu-25145a7d7735344a469551946fc2a7f19eb4aa3d.tar.bz2 | |
hw/net/can/sja1000: fix bug for single acceptance filter and standard frame
A CAN sja1000 standard frame filter mask has been computed and applied
incorrectly for standard frames when single Acceptance Filter Mode
(MOD_AFM = 1) has been selected. The problem has not been found
by Linux kernel testing because it uses dual filter mode (MOD_AFM = 0)
and leaves falters fully open.
The problem has been noticed by Grant Ramsay when testing with Zephyr
RTOS which uses single filter mode.
Signed-off-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Reported-by: Grant Ramsay <gramsay@enphaseenergy.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2028
Fixes: 733210e754 ("hw/net/can: SJA1000 chip register level emulation")
Message-ID: <20240103231426.5685-1-pisa@fel.cvut.cz>
| -rw-r--r-- | hw/net/can/can_sja1000.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/net/can/can_sja1000.c b/hw/net/can/can_sja1000.c index 1165d59..6694d7b 100644 --- a/hw/net/can/can_sja1000.c +++ b/hw/net/can/can_sja1000.c @@ -108,7 +108,7 @@ void can_sja_single_filter(struct qemu_can_filter *filter, } filter->can_mask = (uint32_t)amr[0] << 3; - filter->can_mask |= (uint32_t)amr[1] << 5; + filter->can_mask |= (uint32_t)amr[1] >> 5; filter->can_mask = ~filter->can_mask & QEMU_CAN_SFF_MASK; if (!(amr[1] & 0x10)) { filter->can_mask |= QEMU_CAN_RTR_FLAG; |