diff options
| author | Daniel P. Berrangé <berrange@redhat.com> | 2025-03-17 12:43:00 +0000 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2025-03-19 07:41:32 +0100 |
| commit | 23686dfb763d22d95c05c49382116d77133637b7 (patch) | |
| tree | dc9a84a3d6a223d7ef3636ca1621b38bd37657fa | |
| parent | 6d19d095470221684afe065cffd40adebe644d04 (diff) | |
| download | qemu-23686dfb763d22d95c05c49382116d77133637b7.zip qemu-23686dfb763d22d95c05c49382116d77133637b7.tar.gz qemu-23686dfb763d22d95c05c49382116d77133637b7.tar.bz2 | |
tests/functional: remove all class level fields
A number of fields are set at the class level on QemuBaseTest, even
though the exact same named field is then set at the object level
later in most cases.
The 'self.logger' initialization in ACPI bits test needs to be removed
since 'self.log' won't exist at that point in the flow. It already
initialized 'self.logger' later in the setUp() method, so the __init__
method was redundant.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20250317124300.84266-1-berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
| -rw-r--r-- | tests/functional/qemu_test/testcase.py | 6 | ||||
| -rwxr-xr-x | tests/functional/test_acpi_bits.py | 1 |
2 files changed, 0 insertions, 7 deletions
diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py index 50d232a..50c401b 100644 --- a/tests/functional/qemu_test/testcase.py +++ b/tests/functional/qemu_test/testcase.py @@ -33,12 +33,6 @@ from .uncompress import uncompress class QemuBaseTest(unittest.TestCase): - arch = None - - workdir = None - log = None - logdir = None - ''' @params compressed: filename, Asset, or file-like object to uncompress @params format: optional compression format (gzip, lzma) diff --git a/tests/functional/test_acpi_bits.py b/tests/functional/test_acpi_bits.py index 20da435..8e0563a 100755 --- a/tests/functional/test_acpi_bits.py +++ b/tests/functional/test_acpi_bits.py @@ -119,7 +119,6 @@ class AcpiBitsTest(QemuSystemTest): #pylint: disable=too-many-instance-attribute self._debugcon_addr = '0x403' self._debugcon_log = 'debugcon-log.txt' - self.logger = self.log def _print_log(self, log): self.logger.info('\nlogs from biosbits follows:') |