diff options
| author | Bin Meng <bin.meng@windriver.com> | 2021-02-10 19:22:21 +0800 |
|---|---|---|
| committer | Klaus Jensen <k.jensen@samsung.com> | 2021-02-11 14:22:30 +0100 |
| commit | 2132cfe52bd87f191887c1728190bf56e8d5275f (patch) | |
| tree | dabf7c28791d3348b4057bdab64150ce5399998e | |
| parent | 886188a9c11ff9518c8f20e265e7a98439c14d32 (diff) | |
| download | qemu-2132cfe52bd87f191887c1728190bf56e8d5275f.zip qemu-2132cfe52bd87f191887c1728190bf56e8d5275f.tar.gz qemu-2132cfe52bd87f191887c1728190bf56e8d5275f.tar.bz2 | |
hw/block/nvme: Fix a build error in nvme_get_feature()
Current QEMU HEAD nvme.c does not compile with the default GCC 5.4
on a Ubuntu 16.04 host:
hw/block/nvme.c:3242:9: error: ‘result’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
trace_pci_nvme_getfeat_vwcache(result ? "enabled" : "disabled");
^
hw/block/nvme.c:3150:14: note: ‘result’ was declared here
uint32_t result;
^
Explicitly initialize the result to fix it.
Fixes: aa5e55e3b07e ("hw/block/nvme: open code for volatile write cache")
Fixes: Coverity CID 1446371
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
| -rw-r--r-- | hw/block/nvme.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 02390f1..fb83636 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -3228,6 +3228,7 @@ static uint16_t nvme_get_feature(NvmeCtrl *n, NvmeRequest *req) result = ns->features.err_rec; goto out; case NVME_VOLATILE_WRITE_CACHE: + result = 0; for (i = 1; i <= n->num_namespaces; i++) { ns = nvme_ns(n, i); if (!ns) { |