aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAvihai Horon <avihaih@nvidia.com>2024-12-18 15:40:19 +0200
committerCédric Le Goater <clg@redhat.com>2024-12-26 07:23:38 +0100
commit1f21670ec0700575280bd6aa837eaa8d87fc98c1 (patch)
tree421591081dde14ab1407b3ec710c89e6c30c0e1d
parent6e9df66e8afaa2e2fc98e7a3470edf00ffa16f03 (diff)
downloadqemu-1f21670ec0700575280bd6aa837eaa8d87fc98c1.zip
qemu-1f21670ec0700575280bd6aa837eaa8d87fc98c1.tar.gz
qemu-1f21670ec0700575280bd6aa837eaa8d87fc98c1.tar.bz2
vfio/migration: Rename vfio_devices_all_dirty_tracking()
vfio_devices_all_dirty_tracking() is used to check if dirty page log sync is needed. However, besides checking the dirty page tracking status, it also checks the pre_copy_dirty_page_tracking flag. Rename it to vfio_devices_log_sync_needed() which reflects its purpose more accurately and makes the code clearer as there are already several helpers with similar names. Signed-off-by: Avihai Horon <avihaih@nvidia.com> Reviewed-by: Joao Martins <joao.m.martins@oracle.com> Tested-by: Joao Martins <joao.m.martins@oracle.com> Link: https://lore.kernel.org/r/20241218134022.21264-5-avihaih@nvidia.com Signed-off-by: Cédric Le Goater <clg@redhat.com>
-rw-r--r--hw/vfio/common.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 9b55243..f7499a9 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -191,7 +191,7 @@ bool vfio_devices_all_dirty_tracking_started(
bcontainer->dirty_pages_started;
}
-static bool vfio_devices_all_dirty_tracking(VFIOContainerBase *bcontainer)
+static bool vfio_log_sync_needed(const VFIOContainerBase *bcontainer)
{
VFIODevice *vbasedev;
@@ -1364,7 +1364,7 @@ static void vfio_listener_log_sync(MemoryListener *listener,
return;
}
- if (vfio_devices_all_dirty_tracking(bcontainer)) {
+ if (vfio_log_sync_needed(bcontainer)) {
ret = vfio_sync_dirty_bitmap(bcontainer, section, &local_err);
if (ret) {
error_report_err(local_err);