aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAmador Pahim <apahim@redhat.com>2018-01-22 21:50:31 +0100
committerEduardo Habkost <ehabkost@redhat.com>2018-02-05 19:53:55 -0200
commit17589cae908222d572953d4c85f72aa833e87d58 (patch)
treec6a2b84c23c4d8bfc1d58eb3ade1e66a4593e066
parent04a963b4953be6c7f1899cfe0a0a11d03292c18b (diff)
downloadqemu-17589cae908222d572953d4c85f72aa833e87d58.zip
qemu-17589cae908222d572953d4c85f72aa833e87d58.tar.gz
qemu-17589cae908222d572953d4c85f72aa833e87d58.tar.bz2
qemu.py: use poll() instead of 'returncode'
The 'returncode' Popen attribute is not guaranteed to be updated. It actually depends on a call to either poll(), wait() or communicate(). On the other hand, poll() will: "Check if child process has terminated. Set and return returncode attribute." Let's use the poll() to check whether the process is running and to get the updated process exit code, when the process is finished. Reviewed-by: Fam Zheng <famz@redhat.com> eviewed-by: Eduardo Habkost <ehabkost@redhat.com> Signed-off-by: Amador Pahim <apahim@redhat.com> Message-Id: <20180122205033.24893-5-apahim@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
-rw-r--r--scripts/qemu.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 52cf09e..dcb4f0f 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -150,12 +150,12 @@ class QEMUMachine(object):
raise
def is_running(self):
- return self._popen is not None and self._popen.returncode is None
+ return self._popen is not None and self._popen.poll() is None
def exitcode(self):
if self._popen is None:
return None
- return self._popen.returncode
+ return self._popen.poll()
def get_pid(self):
if not self.is_running():