diff options
| author | Laurent Vivier <lvivier@redhat.com> | 2020-10-09 13:38:43 +0200 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2020-10-13 13:33:46 +0200 |
| commit | 16b66c5626c27b660692f3e60827f58f167e001f (patch) | |
| tree | 1ec68343ce64b6581b5a10fe4ac897afe6381f0a | |
| parent | 9aa2c49eb76838618f1eabd04a688ad2a44c24e5 (diff) | |
| download | qemu-16b66c5626c27b660692f3e60827f58f167e001f.zip qemu-16b66c5626c27b660692f3e60827f58f167e001f.tar.gz qemu-16b66c5626c27b660692f3e60827f58f167e001f.tar.bz2 | |
goldfish_rtc: change MemoryRegionOps endianness to DEVICE_NATIVE_ENDIAN
The doc [1] doesn't define the endianness, but the kernel driver
uses readl() to access the registers, so we can guess it depends
on the architecture endianness.
As riscv architecture endianness is little it might not change anything
for it.
Moreover, android implementation uses DEVICE_NATIVE_ENDIAN [2]
[1] https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT
[2] https://android.googlesource.com/platform/external/qemu/+/refs/heads/emu-master-dev/hw/timer/goldfish_timer.c#177
Fixes: 9a5b40b84279 ("hw: rtc: Add Goldfish RTC device")
Cc: Anup.Patel@wdc.com
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20201009113843.60995-2-lvivier@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
| -rw-r--r-- | hw/rtc/goldfish_rtc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/rtc/goldfish_rtc.c b/hw/rtc/goldfish_rtc.c index 6ddd45c..0f4e818 100644 --- a/hw/rtc/goldfish_rtc.c +++ b/hw/rtc/goldfish_rtc.c @@ -217,7 +217,7 @@ static int goldfish_rtc_post_load(void *opaque, int version_id) static const MemoryRegionOps goldfish_rtc_ops = { .read = goldfish_rtc_read, .write = goldfish_rtc_write, - .endianness = DEVICE_LITTLE_ENDIAN, + .endianness = DEVICE_NATIVE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4 |