diff options
| author | Jamin Lin <jamin_lin@aspeedtech.com> | 2025-08-04 09:46:33 +0800 |
|---|---|---|
| committer | Cédric Le Goater <clg@redhat.com> | 2025-08-04 09:07:38 +0200 |
| commit | 13ed972b4ce57198914a37217251d30fbec20e41 (patch) | |
| tree | bbfe7d4c80513ac8976a4cbbbbdcc3f6fd392061 | |
| parent | d63961f957ffaa586b166846f2c6a580923b08f6 (diff) | |
| download | qemu-13ed972b4ce57198914a37217251d30fbec20e41.zip qemu-13ed972b4ce57198914a37217251d30fbec20e41.tar.gz qemu-13ed972b4ce57198914a37217251d30fbec20e41.tar.bz2 | |
hw/ssi/aspeed_smc: Fix incorrect FMC_WDT2 register read on AST1030
On AST1030, reading the FMC_WDT2 register always returns 0xFFFFFFFF.
This issue is due to the aspeed_smc_read function, which checks for the
ASPEED_SMC_FEATURE_WDT_CONTROL feature. Since AST1030 was missing this
feature flag, the read operation fails and returns -1.
To resolve this, add the WDT_CONTROL feature to AST1030's feature set
so that FMC_WDT2 can be correctly accessed by firmware.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Fixes: 2850df6a81bcdc2e063dfdd56751ee2d11c58030 ("aspeed/smc: Add AST1030 support ")
Link: https://lore.kernel.org/qemu-devel/20250804014633.512737-1-jamin_lin@aspeedtech.com
Signed-off-by: Cédric Le Goater <clg@redhat.com>
| -rw-r--r-- | hw/ssi/aspeed_smc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 614528b..e33496f 100644 --- a/hw/ssi/aspeed_smc.c +++ b/hw/ssi/aspeed_smc.c @@ -1857,7 +1857,8 @@ static void aspeed_1030_fmc_class_init(ObjectClass *klass, const void *data) asc->resets = aspeed_1030_fmc_resets; asc->flash_window_base = 0x80000000; asc->flash_window_size = 0x10000000; - asc->features = ASPEED_SMC_FEATURE_DMA; + asc->features = ASPEED_SMC_FEATURE_DMA | + ASPEED_SMC_FEATURE_WDT_CONTROL; asc->dma_flash_mask = 0x0FFFFFFC; asc->dma_dram_mask = 0x000BFFFC; asc->dma_start_length = 1; |