diff options
| author | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2024-11-07 12:34:42 +0000 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2024-11-26 17:18:06 -0500 |
| commit | 13a4a6ba2bfd3cf9bd34a015929d93868d792de8 (patch) | |
| tree | a897b6ae06d60c0410126375619e027d17829704 | |
| parent | e069c115e00d9eeb1ad6bf224775585c3d30177d (diff) | |
| download | qemu-13a4a6ba2bfd3cf9bd34a015929d93868d792de8.zip qemu-13a4a6ba2bfd3cf9bd34a015929d93868d792de8.tar.gz qemu-13a4a6ba2bfd3cf9bd34a015929d93868d792de8.tar.bz2 | |
hw/acpi: Fix size of HID in build_append_srat_acpi_device_handle()
The size should always be 8 so hard code that. By coincidience the
incorrect use of sizeof(char *) is 8 on 64 bit hosts, but was caught
by CI testing with i686 as the host.
Reported-by: Michael S. Tsirkin <mst@redhat.com>
Closes: https://lore.kernel.org/qemu-devel/20241104110025-mutt-send-email-mst@kernel.org/
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <20241107123446.902801-2-Jonathan.Cameron@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
| -rw-r--r-- | hw/acpi/aml-build.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 6a76626..72282b1 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -1960,7 +1960,7 @@ static void build_append_srat_acpi_device_handle(GArray *table_data, { assert(strlen(hid) == 8); /* Device Handle - ACPI */ - for (int i = 0; i < sizeof(hid); i++) { + for (int i = 0; i < 8; i++) { build_append_int_noprefix(table_data, hid[i], 1); } build_append_int_noprefix(table_data, uid, 4); |