diff options
author | Kevin Wolf <kwolf@redhat.com> | 2018-03-20 18:11:09 +0100 |
---|---|---|
committer | Kevin Wolf <kwolf@redhat.com> | 2018-03-26 12:17:43 +0200 |
commit | 0fcc38e7d0fb102ab9e9a9734459bdff89d3121f (patch) | |
tree | ffaa2f2e2d0aa256838535b321b0fcbe3c59066d | |
parent | b412f49407e81dd6cdd9aaf5310895e579ed21d6 (diff) | |
download | qemu-0fcc38e7d0fb102ab9e9a9734459bdff89d3121f.zip qemu-0fcc38e7d0fb102ab9e9a9734459bdff89d3121f.tar.gz qemu-0fcc38e7d0fb102ab9e9a9734459bdff89d3121f.tar.bz2 |
vhdx: Don't use error_setg_errno() with constant errno
error_setg_errno() is meant for cases where we got an errno from the OS
that can add useful extra information to an error message. It's
pointless if we pass a constant errno, these cases should use plain
error_setg().
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
-rw-r--r-- | block/vhdx.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/block/vhdx.c b/block/vhdx.c index 6a5e48e..4a087d8 100644 --- a/block/vhdx.c +++ b/block/vhdx.c @@ -1822,7 +1822,7 @@ static int coroutine_fn vhdx_co_create(BlockdevCreateOptions *opts, /* Validate options and set default values */ image_size = vhdx_opts->size; if (image_size > VHDX_MAX_IMAGE_SIZE) { - error_setg_errno(errp, EINVAL, "Image size too large; max of 64TB"); + error_setg(errp, "Image size too large; max of 64TB"); return -EINVAL; } @@ -1832,7 +1832,7 @@ static int coroutine_fn vhdx_co_create(BlockdevCreateOptions *opts, log_size = vhdx_opts->log_size; } if (log_size < MiB || (log_size % MiB) != 0) { - error_setg_errno(errp, EINVAL, "Log size must be a multiple of 1 MB"); + error_setg(errp, "Log size must be a multiple of 1 MB"); return -EINVAL; } @@ -1874,7 +1874,7 @@ static int coroutine_fn vhdx_co_create(BlockdevCreateOptions *opts, } if (block_size < MiB || (block_size % MiB) != 0) { - error_setg_errno(errp, EINVAL, "Block size must be a multiple of 1 MB"); + error_setg(errp, "Block size must be a multiple of 1 MB"); return -EINVAL; } if (!is_power_of_2(block_size)) { @@ -1882,8 +1882,7 @@ static int coroutine_fn vhdx_co_create(BlockdevCreateOptions *opts, return -EINVAL; } if (block_size > VHDX_BLOCK_SIZE_MAX) { - error_setg_errno(errp, EINVAL, "Block size must not exceed %d", - VHDX_BLOCK_SIZE_MAX); + error_setg(errp, "Block size must not exceed %d", VHDX_BLOCK_SIZE_MAX); return -EINVAL; } |