diff options
| author | Thomas Huth <thuth@redhat.com> | 2025-08-21 11:47:35 +0200 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2025-08-27 09:46:54 +0200 |
| commit | 0cdabf8adbaca4b370301366faab2d01121289c7 (patch) | |
| tree | 95da801d80b9d69a265696e0b11756bf540bf85f | |
| parent | 36fb9796662e8d1f8626b1cacb1a6d5e35a8bd00 (diff) | |
| download | qemu-0cdabf8adbaca4b370301366faab2d01121289c7.zip qemu-0cdabf8adbaca4b370301366faab2d01121289c7.tar.gz qemu-0cdabf8adbaca4b370301366faab2d01121289c7.tar.bz2 | |
tests/functional: Use more fine-grained locking when looking for free ports
Currently, we have one lock that is held while a test is looking for
free ports. However, we are also using different ranges for looking
for free ports nowadays (PORTS_START is based on the PID of the process),
so instead of using only one lock, we should rather use a lock per
range instead. This should help to allow running more tests in parallel.
While we're at it, also create the lock files without executable bit
(mode is 0o777 by default).
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20250821094735.804210-1-thuth@redhat.com>
| -rw-r--r-- | tests/functional/qemu_test/ports.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tests/functional/qemu_test/ports.py b/tests/functional/qemu_test/ports.py index 631b77a..81174a6 100644 --- a/tests/functional/qemu_test/ports.py +++ b/tests/functional/qemu_test/ports.py @@ -23,8 +23,9 @@ class Ports(): PORTS_END = PORTS_START + PORTS_RANGE_SIZE def __enter__(self): - lock_file = os.path.join(BUILD_DIR, "tests", "functional", "port_lock") - self.lock_fh = os.open(lock_file, os.O_CREAT) + lock_file = os.path.join(BUILD_DIR, "tests", "functional", + f".port_lock.{self.PORTS_START}") + self.lock_fh = os.open(lock_file, os.O_CREAT, mode=0o666) fcntl.flock(self.lock_fh, fcntl.LOCK_EX) return self |