diff options
| author | Markus Armbruster <armbru@redhat.com> | 2013-01-17 13:07:47 +0100 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2013-01-22 15:07:03 +0100 |
| commit | 0bf8264e2d2bd19c1eecf9bde0e59284ef47eabb (patch) | |
| tree | a6939f5d780cca7bd28dc47a081c3395a7a7386d | |
| parent | 032f0101aa6e009efda3a419379837ebceaeade1 (diff) | |
| download | qemu-0bf8264e2d2bd19c1eecf9bde0e59284ef47eabb.zip qemu-0bf8264e2d2bd19c1eecf9bde0e59284ef47eabb.tar.gz qemu-0bf8264e2d2bd19c1eecf9bde0e59284ef47eabb.tar.bz2 | |
scsi: Drop useless null test in scsi_unit_attention()
req was created by scsi_req_alloc(), which initializes req->dev to a
value it dereferences. req->dev isn't changed anywhere else.
Therefore, req->dev can't be null.
Drop the useless null test; it spooks Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
| -rw-r--r-- | hw/scsi-bus.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index 267a942..a97f1cd 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-bus.c @@ -282,7 +282,7 @@ static const struct SCSIReqOps reqops_invalid_opcode = { static int32_t scsi_unit_attention(SCSIRequest *req, uint8_t *buf) { - if (req->dev && req->dev->unit_attention.key == UNIT_ATTENTION) { + if (req->dev->unit_attention.key == UNIT_ATTENTION) { scsi_req_build_sense(req, req->dev->unit_attention); } else if (req->bus->unit_attention.key == UNIT_ATTENTION) { scsi_req_build_sense(req, req->bus->unit_attention); |