aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2013-01-11 11:24:59 +0100
committerMichael Roth <mdroth@linux.vnet.ibm.com>2013-01-14 12:07:48 -0600
commit03ac10f166b790cb66804e512abec6d002cd8481 (patch)
tree463fb89c78932551b6b5b23310a57c52cdb5ea2c
parent5d27f9ce3de424207883d84352d76150e9707394 (diff)
downloadqemu-03ac10f166b790cb66804e512abec6d002cd8481.zip
qemu-03ac10f166b790cb66804e512abec6d002cd8481.tar.gz
qemu-03ac10f166b790cb66804e512abec6d002cd8481.tar.bz2
qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path
Spotted by Coverity. Also document why we keep it open on success. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com> Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
-rw-r--r--qga/main.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/qga/main.c b/qga/main.c
index 96d3cfa..db281a5 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -299,10 +299,12 @@ static bool ga_open_pidfile(const char *pidfile)
goto fail;
}
+ /* keep pidfile open & locked forever */
return true;
fail:
unlink(pidfile);
+ close(pidfd);
return false;
}
#else /* _WIN32 */