diff options
| author | Michael S. Tsirkin <mst@redhat.com> | 2024-07-24 06:48:59 -0400 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2024-08-01 04:32:00 -0400 |
| commit | 024d046bf41b5256adec671085bcee767a6da125 (patch) | |
| tree | d2fe3a259080d4c61179a8e49e5b9735a5ae0282 | |
| parent | e9d2db818ff934afb366aea566d0b33acf7bced1 (diff) | |
| download | qemu-024d046bf41b5256adec671085bcee767a6da125.zip qemu-024d046bf41b5256adec671085bcee767a6da125.tar.gz qemu-024d046bf41b5256adec671085bcee767a6da125.tar.bz2 | |
virtio-rng: block max-bytes=0
with max-bytes set to 0, quota is 0 and so device does not work.
block this to avoid user confusion
Message-Id: <73a89a42d82ec8b47358f25119b87063e4a6ea57.1721818306.git.mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
| -rw-r--r-- | hw/virtio/virtio-rng.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c index f74efff..7cf31da 100644 --- a/hw/virtio/virtio-rng.c +++ b/hw/virtio/virtio-rng.c @@ -184,8 +184,9 @@ static void virtio_rng_device_realize(DeviceState *dev, Error **errp) /* Workaround: Property parsing does not enforce unsigned integers, * So this is a hack to reject such numbers. */ - if (vrng->conf.max_bytes > INT64_MAX) { - error_setg(errp, "'max-bytes' parameter must be non-negative, " + if (vrng->conf.max_bytes == 0 || + vrng->conf.max_bytes > INT64_MAX) { + error_setg(errp, "'max-bytes' parameter must be positive, " "and less than 2^63"); return; } |