aboutsummaryrefslogtreecommitdiff
path: root/winsup
AgeCommit message (Collapse)AuthorFilesLines
3 daysCygwin: bump API version for addition of new/delete wrappersHEADmastermainJeremy Drake1-1/+2
Signed-off-by: Jeremy Drake <cygwin@jdrake.com>
4 daysCygwin: add wrappers for newer new/delete overloadsJeremy Drake5-5/+299
A sized delete (with a std::size_t parameter) was added in C++14 (but doesn't combine with nothrow_t) An aligned new/delete (with a std::align_val_t parameter) was added in C++17, and combinations with the sized delete and nothrow_t variants. Signed-off-by: Jeremy Drake <cygwin@jdrake.com>
9 daysCygwin: mkimport: implement AArch64 +/-4GB relocationsRadek Bartoň2-11/+30
Based on https://sourceware.org/pipermail/cygwin-patches/2025q3/014154.html suggestion, this patch implements +/-4GB relocations for AArch64 in the mkimport script by using adrp and ldr instructions. This change required update in winsup/cygwin/mm/malloc_wrapper.cc where those instructions are decoded to get target import address. Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
10 daysCygwin: Fix handling of archetype fhandler in process_fdTakashi Yano3-0/+7
Previously, process_fd failed to correctly handle fhandlers using an archetype. This was due to the missing PATH_OPEN flag in path_conv, which caused build_fh_pc() to skip archetype initialization. The root cause was a bug where open() did not set the PATH_OPEN flag for fhandlers using an archetype. This patch introduces a new method, path_conv::set_isopen(), to explicitly set the PATH_OPEN flag in path_flags in fhandler_base:: open_with_arch(). Addresses: https://cygwin.com/pipermail/cygwin/2025-May/258167.html Fixes: 92ddb7429065 ("(build_pc_pc): Use fh_alloc to create. Set name from fh->dev if appropriate. Generate an archetype or point to one here.") Reported-by: Christian Franke <Christian.Franke@t-online.de> Reviewed-by: Corinna Vinschen <corinna@vinschen.de> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
11 daysCygwin: Add UTF-8 surrogate fix to release messagesCorinna Vinschen1-0/+7
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
11 daysCygwin: _sys_wcstombs: add FIXME commentCorinna Vinschen1-1/+10
Add a FIXME comment to the conversion of private use area bytes to "normal" bytes in _sys_wcstombs detailing the conversion difference between _sys_wcstombs and standard wcstombs. It might be a good idea to drop the conversion to gather compatibility with wcstombs. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
11 daysCygwin: _sys_mbstowcs: fix handling invalid 4-byte UTF-8 sequencesCorinna Vinschen1-4/+47
When a 4 byte utf-8 sequence has an invalid 4th byte, it's actually an invalid 3 byte sequence. In this case we already generated the high surrogate and only realize the problem when byte 4 doesn't match. At this point _sys_mbstowcs transposes the invalid 4th byte into the private use area. This is wrong. The invalid byte sequence here is the 3 byte sequence already converted to a high surrogate, not the trailing 4th byte. Fix this by backtracking to the start of the broken sequence and overwrite the already written high surrogate with a sequence of the original three bytes transposed to the private use area. Reset the mbstate and restart normal conversion at the non-matching 4th byte, which might start a new multibyte sequence. The resulting wide-char string can be converted back to multibyte and back again to wide-char, and the result will be identical, even if the multibyte sequence differs from the original sequence. Fixes: e44b9069cd227 ("* strfuncs.cc (sys_cp_mbstowcs): Treat src as unsigned char *. Convert failure of f_mbtowc into a single malformed utf-16 value.") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
11 daysCygwin: Add recent fixes to release note 3.6.5Takashi Yano1-0/+7
11 daysCygwin: spawn: Make system() thread-safeTakashi Yano2-3/+5
POSIX states system() shall be thread-safe, however, it is not in current cygwin. This is because ch_spawn is a global and is shared between threads. With this patch, system() uses ch_spawn_local instead which is local variable. popen() has the same problem, so it has been fixed in the same way. Addresses: https://cygwin.com/pipermail/cygwin/2025-June/258324.html Fixes: 1fd5e000ace5 ("import winsup-2000-02-17 snapshot") Reported-by: Takashi Yano <takashi.yano@nifty.ne.jp> Reviewed-by: Corinna Vinschen <corinna@vinschen.de> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
11 daysCygwin: spawn: Lock cygheap from refresh_cygheap() until child_copy()Takashi Yano1-5/+7
...completion in child process because the cygheap should not be changed to avoid mismatch between child_info::cygheap_max and ::cygheap_max. Otherwise, child_copy() might copy cygheap being modified by other process. In addition, to avoid deadlock, move close_all_files() for non- Cygwin processes after unlocking cygheap, since close_all_files() calls cfree(), which attempts to lock cygheap even when it's already locked. Fixes: 977ad5434cc0 ("* spawn.cc (spawn_guts): Call refresh_cygheap before creating a new process to ensure that cygheap_max is up-to-date.") Reviewed-by: Corinna Vinschen <corinna@vinschen.de> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
11 daysCygwin: cygheap: Add lock()/unlock() methodTakashi Yano2-6/+11
...so that cygheap can be locked/unlocked from outside of mm/cygheap.cc. Reviewed-by: Corinna Vinschen <corinna@vinschen.de> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
12 daysCygwin: doc: add note about raw devices of BitLocker partitionsChristian Franke1-0/+6
Signed-off-by: Christian Franke <christian.franke@t-online.de>
13 daysCygwin: configure: add possibility to skip build of cygserver and utilsRadek Bartoň4-3/+48
This patch adds configure options allowing to disable build of cygserver and Cygwin utilities. This is useful when one needs to build only cygwin1.dll and crt0.o with stage1 compiler that is not yet capable of linking executables as it is missing cygwin1.dll and crt0.o. Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-07-18Cygwin: clocks: read leap secs from /etc/leapsecs on older systemsCorinna Vinschen1-49/+39
Systems prior to W10 1803 don't have the leapsecs registry key HKLM\SYSTEM\CurrentControlSet\Control\LeapSecondInformation and don't handle leap seconds at all. Given that new leap seconds are a rather seldom, irregular event, drop reading from /usr/share/zoneinfo/leapseconds. Just read the same leap second records from a file /etc/leapsecs as stored in the LeapSeconds registry value on newer systems instead. As a sidenote, the code reading from /usr/share/zoneinfo/leapseconds was wrong anyway, because it didn't take the timestamps into account. Given IERS publishes new leap seconds about 6 months before they occur, CLOCK_TAI would have been one second off for up to 6 months. /etc/leapsecs doesn't exist yet, so we just default to 37 secs. If new leap seconds get provided for newer systems, make sure to provide the /etc/leapsecs file as part of the Cygwin distro with identical entries. Fixes: 2abb929f0ad2 ("Cygwin: clocks: Implement CLOCK_TAI") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-07-18Cygwin: sys/termios.h: define struct winsize before using itCorinna Vinschen2-8/+10
Long-standing bug in the sys/termios.h file which, for some reason, has never been encountered before. STC: #include <sys/termios.h> int main() { struct winsize win; tcgetwinsize (0, &win); } Result with gcc 12.4.0: termios-bug.c: In function ‘main’: termios-bug.c:7:20: warning: passing argument 2 of ‘tcgetwinsize’ from incompatible pointer type [-Wincompatible-pointer-types] 7 | tcgetwinsize (0, &win); | ^~~~ | | | struct winsize * In file included from termios-bug.c:1: /usr/include/sys/termios.h:304:42: note: expected ‘struct winsize *’ but argument is of type ‘struct winsize *’ 304 | int tcgetwinsize(int fd, struct winsize *winsz); | ~~~~~~~~~~~~~~~~^~~~~ This warning apparently becomes an error with C23. The reason is that struct winsize is defined in sys/termios.h after using it as argument type in function declarations. From the compil;er perspective it's now a different type , regardless of having the same name. Move declaration of struct winsize up so it's defined before being used. Reported-by: Zachary Santer <zsanter@gmail.com> Suggested-by: Zachary Santer <zsanter@gmail.com> Addresses: https://cygwin.com/pipermail/cygwin/2025-July/258474.html Fixes: 1fd5e000ace55 ("import winsup-2000-02-17 snapshot") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-07-17Cygwin: clocks: read leap seconds from registryCorinna Vinschen1-7/+73
Windows 10 1803 introduced leap seconds support in 2018. The OS always starts at 37 leap secs. Additional leap second timestamps are added to the registry key HKLM\SYSTEM\CurrentControlSet\Control\LeapSecondInformation, value LeapSeconds. If the key exists, read the leap second timestamps from this value, otherwise fallback to reading /usr/share/zoneinfo/leapseconds. Note that we might change the file we read from yet, but that's no part of this patch. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-07-17Cygwin: reg_key: add a method get_binary() to fetch REG_BINARY dataCorinna Vinschen2-0/+41
This patch is required for a followup patch fetching the leap seconds info from the registry starting with Windows 10 1803. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-07-17Cygwin: cygcheck: port to AArch64Radek Bartoň1-3/+11
This patch ports `winsup/utils/mingw/cygcheck.cc` to AArch64: - Adds arch=aarch64 to packages API URL. - Ports dll_info function. Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-07-16Cygwin: testsuite: link cygload with --disable-high-entropy-vaJeremy Drake1-1/+1
This is a mingw program meant to demonstrate loading the Cygwin dll in a non-Cygwin process, but the Cygwin dll still initializes the cygheap on load in that case. Without --disable-high-entropy-va, Windows may occasionally locate the PEB, TEB, and/or stacks in the address space that Cygwin tries to reserve for the cygheap, resulting in a failure. Fixes: 60675f1a7eb2 ("Cygwin: decouple shared mem regions from Cygwin DLL") Signed-off-by: Jeremy Drake <cygwin@jdrake.com>
2025-07-16Cygwin: clocks: Implement CLOCK_TAICorinna Vinschen6-5/+102
CLOCK_TAI is like CLOCK_REALTIME ignoring leap secs. Right now, 2025, it has a positive 37 secs offset from CLOCK_REALTIME. Given the unpredictability of adding leap secs by the IERS (International Earth Rotation and Reference Systems Service), we also add a mechanism to read the current leap secs offset from /usr/share/zoneinfo/leapseconds, part of the tzdata package. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-07-16Cygwin: add clock bugfixes to 3.6.5 release messageCorinna Vinschen1-0/+4
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-07-16Cygwin: POSIX timer: handle TIMER_ABSTIME correctly for all realtime clocksCorinna Vinschen1-1/+3
Add CLOCK_REALTIME_COARSE and CLOCK_REALTIME_ALARM to the clocks allowing an absolute timeout value to be used as such in NtSetTimer. Fixes: c05df02725c59 ("Cygwin: implement extensible clock interface") Fixes: 013e2bd9ecf85 ("Cygwin: posix timers: Add support for CLOCK_REALTIME_ALARM/CLOCK_BOOTTIME_ALARM") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-07-16Cygwin: clocks: use InterlockedCompareExchange64Corinna Vinschen1-6/+3
The clock init functions checked timer ticks/period for 0 and then called InterlockedExchange64 if the value was still 0. This is not quite as atomic as it was supposed to be. Use InterlockedCompareExchange64 instead. Fixes: 2b72887ac834b ("Cygwin: clocks: fix a hang on pre-Windows 10 machines") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-07-15Cygwin: doc: Install miscellaneous website filesJon Turney1-3/+7
This gives us a full set of the built documentation files in the install directory, which can then be appropriately filtered for packaging or deploying to website, as required. Again, there will be a separate change to the cygwin packaging to avoid including theses files in the cygwin-doc package. Also, add matching uninstall rules.
2025-07-15Cygwin: doc: Install FAQ as wellJon Turney1-1/+8
We don't currrently deploy the CSS file to the website, because the FAQ doesn't get installed, so instead we copy all the doc files from the build directory. That omits docbook.css, which is installed from directly from the source directory. (We just happen to have a similar file lying around on the webserver). Instead, just install the FAQ. There will be a separate change to the cygwin packaging to avoid including the FAQ in the cygwin-doc package. (I guess we'd rather people go online for that, to ensure they have the latest version?) Also, add matching uninstall rules.
2025-07-14Cygwin: gendef: stub implementations of routines for AArch64Radek Bartoň1-1/+41
This patch aspires to provide only minimal changes to `winsup/cygwin/scripts/gendef` allowing to pass the AArch64 build. It does not provide any implementations of the generated routines. Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-07-14Cygwin: doc: warn about unprivileged access to raw devicesChristian Franke1-1/+9
Raw devices of partitions may be accessible from unprivileged processes, for example if connected via USB. Signed-off-by: Christian Franke <christian.franke@t-online.de>
2025-07-14Cygwin: signal: make context structures registers handling portableRadek Bartoň6-35/+135
This patch extracts macros from winsup/cygwin/exceptions.cc serving for portable register access to context structures into a separate local header winsup/cygwin/local_includes/register.h and implements their AArch64 counterparts. Then, it adds AArch64 declaration of __mcontext structure based on mingw-w64-headers/include/winnt.h header to winsup/cygwin/include/cygwin/singal.h header. Then, it includes the registers.h header and uses the macros where applicable, namely at: - winsup/cygwin/exceptions.cc - winsup/cygwin/profil.c - winsup/cygwin/tread.cc The motivation is to make usage of the context structures portable without unnecessary #if defined(__x86_64__) while implementations of signal handling code will be developed later, e.g. implementation of makecontext. Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-07-14Cygwin: malloc_wrapper: port to AArch64Evgeny Karpov1-0/+14
Implements import_address function by decoding adr AArch64 instructions to get target address. Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-07-14Cygwin: add dummy implementation of _fe_nomask_envRadek Bartoň1-0/+10
_fe_nomask_env is exported by cygwin.din but not used at all for AArch64. Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-07-14Cygwin: dumper: port to AArch64Radek Bartoň1-1/+3
This patch allows to build winsup/utils/dumper.cc for AArch64 by handling target architecture condition in dumper::init_core_dump. Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-07-14Cygwin: profiler: port to AArch64Radek Bartoň1-1/+3
This patch allows to build winsup/utils/profiler.cc for AArch64 by handling target architecture condition in find_text_section function implementation. Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-07-14Cygwin:testsuite: winchild: drop unused variableCorinna Vinschen1-1/+0
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-07-14Cygwin: mkimport: port to support AArch64Radek Bartoň1-0/+11
This patch ports winsup/cygwin/scripts/mkimport script to AArch64, namely implements relocation to the imp_sym. Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-07-14Cygwin: pty: TCIFLUSH also clears readahead buffer in the masterTakashi Yano3-5/+30
Previously, TCIFLUSH flushed the pipe to_slave which transfers input from master to slave. However, this was not sufficiant. The master side holds input data before accept_input() in the read-ahead buffer. So, if input data before 'enter' key can be leaked into slave input after TCIFLUSH. With this patch, TCIFLUSH requests master to flush read-ahead buffer via master control pipe. To realize this, add cmd filed to pipe_request structure so that the flush request can be distinguished from existing pipe handle request. Addresses: https://cygwin.com/pipermail/cygwin/2025-July/258442.html Fixes: 41946df6111b (" (fhandler_tty_slave::tcflush): Implement input queue flushing by calling read with NULL buffer.") Reported-by: Christoph Reiter <reiter.christoph@gmail.com> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2025-07-11Cygwin: winchild: fix missing stdlib.hRadek Bartoň1-1/+1
The posix_spawn/winchild test was added recently by 2af1914b6ad673a2041cf94cc8e78e1bdec57a27 commit. It fails to build for AArch64 due to missing stdlib.h header where malloc and free functions are defined. This patch fixes the missing header. Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-07-09Cygwin: testsuite: test posix_spawn_file_actions_addopen with O_CLOEXECJeremy Drake1-0/+10
This was previously not handled correctly by newlib. Signed-off-by: Jeremy Drake <cygwin@jdrake.com>
2025-07-09Cygwin: CI: cygstress: remove 'filerace', 'flock' and 'fork' from CIChristian Franke1-3/+4
The 'filerace' test may run longer than the watchdog timeout. 'flock' and 'fork' may leave processes behind for some unknown reason. Signed-off-by: Christian Franke <christian.franke@t-online.de>
2025-07-08Cygwin: open: only fix file attributes when trying to create fileCorinna Vinschen2-2/+5
Only try to fix the cached DOS attributes if the caller actually tried to create the file. Otherwise the fixup code is called even in cases where we open the file with minimal query access bits and NtQueryInformationFile() could fail with STATUS_ACCESS_DENIED and the new cached DOS attributes are wrong again. Fixes: 37c49decc835f ("Cygwin: open: only fix up cached DOS file attributes for on-disk files") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-07-07Cygwin: spawn: apply PID_NEW_PG flag to spawned childJeremy Drake1-6/+11
Previously, it was always applied to "myself", which is only appropriate in the case of _P_OVERLAY (aka exec). Apply the flag to "myself" only in that case, and apply it to the new child instead in other cases. Also, clear the flag from "myself" in the case of a failed exec. Fixes: 8d8724ee1b5a ("Cygwin: pty: Fix Ctrl-C handling further for non-cygwin apps.") Signed-off-by: Jeremy Drake <cygwin@jdrake.com>
2025-07-07Cygwin: define OUTPUT_FORMAT and SEARCH_DIR for AArch64Radek Bartoň1-1/+3
This patch defines binutils output binary format for AArch64 which is pei-aarch64-little. Since =/usr/lib/w32api resolves to $SYSROOT/usr/lib/w32api and Fedora cross-build takes libraries from /usr/aarch64-pc-cygwin/sys-root/usr/lib/w32api, the SEARCH_DIR("/usr/x86_64-pc-cygwin/lib/w32api"); is redundant and can be removed. Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-07-05Cygwin: CI: cygstress: add ability to run all tests multiple timesChristian Franke1-28/+135
Add options '-e' and '-r' to control error behavior and number of test runs. Signed-off-by: Christian Franke <christian.franke@t-online.de>
2025-07-05Cygwin: CI: cygstress: update for stress-ng 0.19.02 and current CygwinChristian Franke1-29/+35
Signed-off-by: Christian Franke <christian.franke@t-online.de>
2025-07-03Cygwin: gentls_offsets: port to support AArch64Radek Bartoň1-2/+2
Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-07-03Cygwin: GetArm64ProcAddress: drop unsupported __i386__ code branchCorinna Vinschen1-4/+1
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-07-03Cygwin: add fastcwd to AArch64 buildRadek Bartoň1-0/+5
Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-07-03Cygwin: format_process_maps: avoid crashing PID when fetching heap infoCorinna Vinschen2-3/+34
To fetch heap info for a process in our /proc/PID/maps emulation, we call RtlQueryProcessDebugInformation on this process since commit b4966f91396b ("(heap_info::heap_info): Rearrange using RtlQueryProcessDebugInformation"). However, it turns out that this call can crash the targeted process, if it's called from multiple threads or processes in parallel. Worse, the entire code from creating the debug buffer, over fetching the debug info, subsequent collecting the information from said debug buffer, up to destroying the buffer, needs to be guarded against parallel access. We do this by adding a global mutex object, serializing access to the debug info of a process. Reported-by: Christian Franke <Christian.Franke@t-online.de> Fixes: b4966f91396b ("(heap_info::heap_info): Rearrange using RtlQueryProcessDebugInformation") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-07-03Cygwin: dlsym: fetch module list via EnumProcessModulesCorinna Vinschen2-24/+13
We're using RtlQueryProcessDebugInformation from dlsym since commit 31ddf45dd8694 ("* autoload.cc (EnumProcessModules): Remove.") Observations on the Cygwin mailing list show that calling RtlQueryProcessDebugInformation on a process is neither thread-safe, nor multi-process-safe, see https://cygwin.com/pipermail/cygwin/2025-July/258403.html for details. This patch essentially reverts 31ddf45dd8694. Fetch the list of loaded modules in the current process by calling EnumProcessModules again. Reported-by: Christian Franke <Christian.Franke@t-online.de> Fixes: 31ddf45dd8694 ("* autoload.cc (EnumProcessModules): Remove.") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-07-03Cygwin: console: Set console mode only if std{in,out,err} is consoleTakashi Yano2-15/+27
Currently, when cygwin app is launched, the console input mode is set to tty::cygwin, even if the stdin is not a console. However, it is not necessary because the cygwin app does not use stdin. This also applies to stdout and stderr. With this patch, the console mode is set only when std{in,out,err} is a console for the cygwin app for better coexistence with non- cygwin apps. Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2025-07-03Cygwin: console: Call set_input_mode() after changing disable_master_threadTakashi Yano1-4/+9
With the commit 476135a24506, set_input_mode() reffers to the flag disable_master_thread in tty::cygwin mode. So it is necessary to call set_input_mode() after changing disable_master_thread flag. However, the commit 476135a24506 was missing that. With this patch, set_input_mode() is called after changing the flag disable_master_thread, if the console input mode is tty::cygwin. Fixes: 476135a24506 ("Cygwin: console: Set ENABLE_PROCESSED_INPUT when disable_master_thread"); Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
generated by cgit v1.1 at 2025-08-03 22:01:22 +0000