aboutsummaryrefslogtreecommitdiff
path: root/winsup
AgeCommit message (Collapse)AuthorFilesLines
2002-09-30Remove \n from calls to strace class printfs throughout.Christopher Faylor17-50/+54
2002-09-30remove newlineChristopher Faylor1-1/+1
2002-09-30* exceptions.cc (unused_sig_wrapper): Accommodate newer compilers.Christopher Faylor3-5/+14
2002-09-30* security.cc (allow_ntsec): Default to zero.Christopher Faylor3-3/+7
* environ.cc (environ_init): Set allow_ntsec to TRUE by default, assuming OS allows it.
2002-09-30* cygpath.cc (close_arg): Remove unused static.Christopher Faylor5-12/+20
* mkgroup.c (enum_local_users): Avoid compiler warning. (enum_users): Ditto. * mkpasswd.c: Ditto throughout. * ssp.c: Ditto throughout.
2002-09-30* environ.cc (environ_init): Avoid a compiler warning.Christopher Faylor10-16/+24
* path.cc (path_conv::check): Ditto. * path.h (path_conv::operator int): Ditto. * regex/engine.c: Ditto throughout. * regex/regcomp.c: Ditto throughout. * regex/regexec.c: Ditto throughout.
2002-09-30* thread.cc: Use "%E" in *_printf throughout rather than calling GetLastError.Christopher Faylor2-158/+152
GNUify comments. (__pthread_mutex_lock): Don't return error on EBUSY since that just means that the mutex has already been initialized.
2002-09-29GNUify slightly.Christopher Faylor1-10/+9
2002-09-292002-09-30 Robert Collins <rbtcollins@hotmail.com>Robert Collins4-14/+73
* pthread.cc (pthread_mutex_init): Use new pthread_mutex::init. * thread.cc: Change __pthread_mutex_init to pthread_mutex::init throughout. (MTinterface::Init): Initialise pthread_mutex support. (pthread_mutex::mutexInitializationLock): Instantiate. (pthread_mutex::initMutex): New method. (__pthread_cond_dowait): Don't dereference untrusted pointers. Use the new pthread_mutex::init method. (__pthread_condattr_init): Don't dereference untrusted pointers. (__pthread_mutex_init): Rename to pthread_mutex::init. Lock and release mutexInitializationLock to prevent races on mutex initialisation. * thread.h (pthread_mutex::initMutex): New method, initialise pthread_mutex supporting state on process initialisation. (pthread_mutex::init): Initialise a single mutex. (pthread_mutex::mutexInitializationLock): A win32 mutex for syncronising pthread mutex initialisation. (__pthread_mutex_init): Remove this.
2002-09-29Add missing ChangeLog entry.Christopher Faylor1-0/+4
2002-09-29* cygthread.h (cygthread::terminate): Declare new function.Christopher Faylor5-89/+125
(cygthread::initialized): Change to 'int'. * cygthread.cc (cygthread::stub): Exit thread if initialized < 0. (cygthread::new): Ditto. (cygthread::runner): Ditto. Set initialized using xor to preserve sign. (cygthread::terminate): New function. * dcrt0.cc (do_exit): Call cygthread::terminate.
2002-09-28* Makefile.in (check): Be more defensive when creating testsuite config.status.Christopher Faylor2-1/+6
2002-09-272002-09-27 Robert Collins <rbtcollins@hotmail.com>Robert Collins3-4/+23
* thread.cc (pthread_key::run_destructor): Run_destructor is not const as it needs to set the key value. * thread.h (pthread_key::run_destructor): Ditto. 2002-09-27 Robert Collins <rbtcollins@hotmail.com> * thread.cc (pthread_key::run_destructor): Follow opengroup algorithm. I.e. only run the destructor NON-NULL key values, and reset the key to NULL before running the destructor. Reported by Thomas Pfaff.
2002-09-25* cygrun.c (main): Fix setting of CYGWIN environment variable.Christopher Faylor2-2/+11
* Makefile.in: Remove linking of unnecessary libraries.
2002-09-25* fhandler_proc.cc (format_process_stat): make ctty a real device number.Christopher Faylor4-34/+31
(format_process_status): use effective uid/gid as real and saved uid/gid.
2002-09-24 * errno.cc (errmap): Map ERROR_INVALID_ADDRESS to new errno codeCorinna Vinschen3-6/+22
EOVERFLOW. (_sys_errlist): Add entries for EILSEQ and EOVERFLOW. (strerror): Ditto. * mmap.cc (map_map): Set errno in case of error. (mmap64): Remove setting errno explicitely to ENOMEM.
2002-09-24 * mmap.cc (map_map): Add debug output.Corinna Vinschen2-1/+7
(mmap64): Evaluate gran_len correctly even if offset isn't 0.
2002-09-24 * include/ws2tcpip.h: Throw error if winsock.h, not winsock2.hDanny Smith2-4/+11
has been included first.
2002-09-242002-09-24 Rene Moeller Fonseca <fonseca@users.sourceforge.net>Danny Smith4-3/+10
* include/winbase.h (FindFirstFileEx): Fixed ANSI mode. * include/wingdi.h (PFD_SWAP_LAYER_BUFFERS):Added define. * include/winuser.h (AppendMenu[AW]): Fixed prototypes.
2002-09-23More GNUify non-GNU formatted functions calls throughout.Christopher Faylor23-78/+77
2002-09-22Reset ChangeLog dates from cygwin_daemon merge.Christopher Faylor1-63/+63
2002-09-22white space.Christopher Faylor1-5/+5
2002-09-22* Makefile.in (DLL_O_FILES): Restore formatting.Christopher Faylor2-22/+25
2002-09-222002-09-22 Conrad Scott <conrad.scott@dsl.pipex.com>Conrad Scott41-4543/+9524
GNUify non-GNU formatted functions calls throughout. 2002-09-22 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_shm.cc (with_strerr): Remove macro. (server_shmmgr::segment_t::~segment_t): Remove calls to with_strerr. (server_shmmgr::segment_t::attach): Ditto. (server_shmmgr::new_segment): Ditto. * shm.cc (with_strerr): Remove macro. (client_shmmgr::shmdt): Remove calls to with_strerr. (client_shmmgr::attach): Ditto. 2002-09-21 Conrad Scott <conrad.scott@dsl.pipex.com> * include/sys/ipc.h: Move to "include/cygwin/ipc.h". * include/sys/msg.h: Move to "include/cygwin/msg.h". * include/sys/sem.h: Move to "include/cygwin/sem.h". * include/sys/shm.h: Move to "include/cygwin/shm.h". * include/cygwin/ipc.h: New file. * include/cygwin/msg.h: Ditto. * include/cygwin/sem.h: Ditto. * include/cygwin/shm.h: Ditto. * cygserver_shm.h: Update includes. * msg.cc: Ditto. * sem.cc: Ditto. 2002-09-21 Conrad Scott <conrad.scott@dsl.pipex.com> * safe_memory.h (safe_delete): Make a templated function. * cygserver.cc (~server_request): Update use of safe_delete. (main): Ditto. * cygserver_client.cc (client_request::handle_request): Ditto. (client_request::make_request): Ditto. * cygserver_process.cc (~process_cleanup): Ditto. (process::remove): Ditto. (process::cleanup): Ditto. (process_cache::process): Ditto. * cygserver_shm.cc (server_shmmgr::segment_t::detach): Ditto. (server_shmmgr::delete_segment): Ditto. * shm.cc (client_shmmgr::shmdt): Ditto. * threaded_queue.cc (~threaded_queue): Ditto. (threaded_queue::worker_loop): Ditto. 2002-08-29 Conrad Scott <conrad.scott@dsl.pipex.com> * safe_memory.h: Replace #include <new> with an explicit definition of the placement new operator. (safe_delete): Remove unnecessary ## operator. 2002-07-28 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_shm.cc (class server_shmmgr): Remove `cleanup_t' friend declaration. (cleanup_t::cleanup_t): Use the segment's shmid as the key rather than the segment pointer itself. (cleanup_t::segptr): Remove method. (cleanup_t::shmid): New method. (cleanup_t::cleanup): Update for new key value. (server_shmmgr::find (segment_t *)): Remove method. * include/cygwin/cygserver_process.h (cleanup_routine::key): Make method const. 2002-07-27 Conrad Scott <conrad.scott@dsl.pipex.com> * include/cygwin/cygserver_process.h (cleanup_routine::_key): New field. (cleanup_routine::cleanup_routine): Initialise new field with new argument. (cleanup_routine::operator==): New method. (cleanup_routine::key): New method. (cleanup_routine::cleanup): Make argument non-const. (process::is_active): New method. (process::remove): Ditto. (process::check_exit_code): Rename method. * cygserver_process.cc (process::add): Reorganize code. (process::remove): New method. (process::check_exit_code): Rename method. (process::cleanup): Use new `process::is_active' method. (process_cache::process): Ditto. (process_cache::sync_wait_array): Ditto. (process_cache::check_and_remove_process): Ditto. * cygserver_shm.cc (server_shmmgr): Make `cleanup_t' a friend. (segment_t::detach): Make argument non-const. Remove cleanup object from client if appropriate. (cleanup_t::_segptr): Remove field. (cleanup_t::cleanup_t): Initialise parent explicitly. Remove field. (cleanup_t::segptr): New method. (cleanup_t::cleanup): Add error checking and reporting. (server_shmmgr::shmdt): Make argument non-const. (server_shmmgr::find (segment_t *)): New method. 2002-07-27 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver.cc (client_request_shutdown::client_request_shutdown): Comment out verbose tracing statement. * cygserver_client.cc (client_request_get_version::client_request_get_version): Ditto. (client_request_attach_tty::client_request_attach_tty): Ditto. * cygserver_shm.cc (client_request_shm::client_request_shm): Ditto. 2002-07-27 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_transport_pipes.cc (transport_layer_pipes::listen): Set `_is_listening_endpoint' appropriately. 2002-07-27 Conrad Scott <conrad.scott@dsl.pipex.com> * include/cygwin/cygserver_transport.h (transport_layer_base::listen): Change return type. (transport_layer_base::connect): Ditto. * include/cygwin/cygserver_transport_pipes.h (transport_layer_pipes::listen): Change return type. (transport_layer_pipes::connect): Ditto. (transport_layer_pipes::_sec_none_nih): Remove unused field. (transport_layer_pipes::_is_listening_endpoint): New field. * cygserver_transport_pipes.cc: Synchronize with sockets code. (transport_layer_pipes::transport_layer_pipes): Initialise new field. Separate out asserts. (transport_layer_pipes::listen): Change return type. Add asserts. (transport_layer_pipes::accept): Add asserts. (transport_layer_pipes::read): Change conditional to an assert. Add assert. (transport_layer_pipes::write): Ditto. (transport_layer_pipes::connect): Change return type. Change conditional to an assert. Add asserts. Rationalize error code slightly. (transport_layer_pipes::impersonate_client): Add asserts. * include/cygwin/cygserver_transport_sockets.h (transport_layer_sockets::listen): Change return type. (transport_layer_sockets::connect): Ditto. (transport_layer_sockets::_addr): Change type of field. (transport_layer_sockets::_addr_len): Ditto. (transport_layer_sockets::_is_accepted_endpoint): New field. (transport_layer_sockets::_is_listening_endpoint): Ditto. * cygserver_transport_sockets.cc (MAX_CONNECT_RETRY): New constant. (transport_layer_sockets::transport_layer_sockets): Initialise new fields. Only initialise the socket address where necessary. (transport_layer_sockets::listen): Change return type. Rewrite. (transport_layer_sockets::accept): Add asserts. Add tracing statements. Use a local variable to hold the accepted address. (transport_layer_sockets::close): Add tracing statements. Unlink the UNIX domain socket file as appropriate. Close the socket cleanly. (transport_layer_sockets::read): Rewrite method. (transport_layer_sockets::write): Ditto. (transport_layer_sockets::connect): Change return type. Rewrite. * cygserver.cc (server_submission_loop::request_loop): Run the listening thread at high priority with special handling for shutdown. (main): Print the request error code rather than errno in shutdown request code. Install signal handlers with sigaction(2) to avoid setting SA_RESTART. Check value of the listen method call, now it has one. * cygserver_client.cc (client_request::make_request): Check new return value on connect method call. 2002-07-27 Conrad Scott <conrad.scott@dsl.pipex.com> * include/cygwin/cygserver_transport_pipes.h (cygserver_transport_pipes::_sd): Rename field. (cygserver_transport_pipes::_sec_none_nih): Ditto. (cygserver_transport_pipes::_sec_all_nih): Ditto. (cygserver_transport_pipes::_pipe_name): Ditto. (cygserver_transport_pipes::_hPipe): Ditto. (cygserver_transport_pipes::_is_accepted_endpoint): Ditto. * cygserver_transport_pipes.cc (transport_layer_pipes::transport_layer_pipes): Rename fields. (transport_layer_pipes::init_security): Ditto. (transport_layer_pipes::listen): Ditto. (transport_layer_pipes::accept): Ditto. (transport_layer_pipes::close): Ditto. (transport_layer_pipes::read): Ditto. (transport_layer_pipes::write): Ditto. (transport_layer_pipes::connect): Ditto. (transport_layer_pipes::impersonate_client): Ditto. (transport_layer_pipes::revert_to_self): Ditto. * include/cygwin/cygserver_transport_sockets.h (cygserver_transport_sockets::_fd): Rename field. (cygserver_transport_sockets::_addr): Ditto. (cygserver_transport_sockets::_addr_len): Ditto. * cygserver_transport_sockets.cc (transport_layer_sockets::transport_layer_sockets): Rename fields. (transport_layer_sockets::listen): Ditto. (transport_layer_sockets::accept): Ditto. (transport_layer_sockets::close): Ditto. (transport_layer_sockets::read): Ditto. (transport_layer_sockets::write): Ditto. (transport_layer_sockets::connect): Ditto. 2002-07-27 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_shm.cc (with_strerr): Fix use of %p format. * shm.cc (client_shmmgr::shmat): Ditto. (client_shmmgr::shmctl): Ditto. (client_shmmgr::shmdt): Ditto. (client_shmmgr::attach): Ditto. 2002-07-14 Christopher Faylor <cgf@redhat.com> * woutsup.h (system_printf): Remove extraneous semicolon from macro definition. 2002-07-14 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_transport_pipes.cc (transport_layer_pipes::connect): Use ProtectHandle in DLL code. (transport_layer_pipes::close): Use ForceCloseHandle in DLL code. 2002-07-13 Nicholas Wourms <nwourms@netscape.com> * threaded_queue.h (class queue_submission_loop): Correct friend declaration for GCC 3.1.1. * include/cygwin/cygserver_process.h (class process): Ditto. (class process_cache): Ditto. 2002-07-12 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_shm.cc (server_shmmgr::shmdt): Only call delete_segment if the segment exists [sic]. 2002-07-12 Conrad Scott <conrad.scott@dsl.pipex.com> * safe_memory.h: Include <new> rather than <new.h> for gcc 3. 2002-07-11 Conrad Scott <conrad.scott@dsl.pipex.com> * safe_memory.h: New file extracted from "woutsup.h". * woutsup.h: Move the "safe" new/delete macros into the new "safe_memory.h" header file and include that here. * cygserver_client.cc: Explicitly include "safe_memory.h" for client-side code. (client_request::make_request): Use the "safe" new/delete macros unconditionally, i.e. use them on the client side as well as on the server side. * cygserver_transport.cc: Explicitly include "safe_memory.h" for client-side code. (create_server_transport): Use the "safe" new/delete macros unconditionally, i.e. use them on the client side as well as on the server side. * shm.cc: Include "safe_memory.h". (client_shmmgr::instance): Use the "safe" new/delete macros. (client_shmmgr::shmdt): Ditto. (client_shmmgr::new_segment): Ditto. 2002-07-11 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_process (process::process): Add the client's cygpid and winpid to all tracing statements as appropriate. (process::exit_code): Ditto. (process_cache::check_and_remove_process): Ditto. * cygserver_shm.cc (server_shmmgr::shmat): Ditto. (server_shmmgr::shmdt): Ditto. (server_shmmgr::shmctl): Add a process object argument and remove the explicit cygpid argument. Add the client's cygpid and winpid to all tracing statements as appropriate. (server_shmmgr::shmget): Ditto. (client_request_shm::serve): Update for the new signature of the shmctl and shmget methods. 2002-07-11 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver.cc (client_request_shutdown::serve): Don't set the shutdown flag directly, but send a SIGINT, as the signal handler sets the flag and the signal breaks the pause(2) in the main loop. (print_usage): Add new options. (main): Add new --cleanup-threads and --request-threads options to set the number of threads used by the daemon. Use pause(2) rather the win32 Sleep in the main loop. * shm.cc (shmat): Add sigframe. (shmctl): Ditto. (shmdt): Ditto. (shmget): Ditto. 2002-07-11 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_shm.cc: Automatically detach processes from any segments they are attached to at exit. (class server_shmmgr::attach_t): New class. (server_shmmgr::segment_t::IS_DELETED): Rename and make private. (server_shmmgr::segment_t::_sequence): Make private. (server_shmmgr::segment_t::_flg): Ditto. (server_shmmgr::segment_t::_hFileMap): Ditto. (server_shmmgr::segment_t::_attach_head): New private field. (server_shmmgr::segment_t::segment_t): Initialise new fields. Make non-inline. (server_shmmgr::segment_t::~segment_t): New method. (server_shmmgr::segment_t::is_deleted): Ditto. (server_shmmgr::segment_t::is_pending_delete): Ditto. (server_shmmgr::segment_t::mark_deleted): Ditto. (server_shmmgr::segment_t::attach): Ditto. (server_shmmgr::segment_t::detach): Ditto. (server_shmmgr::segment_t::find): Ditto. (class server_shmmgr::cleanup_t): New class. (server_shmmgr::_shm_atts): New private field. (server_shmmgr::shmat): Add a process object argument to replace the removed process_cache, cygpid and winpid arguments. Remove the process_cache manipulations. Move body of code to the segment_t::attach method. Increment _shm_atts when required. Update tracing statements. (server_shmmgr::shmdt): Add a process object argument to replace the removed cygpid argument. Move body of code to the segment_t::detach method. Decrement _shm_atts when required. Update tracing statements. (server_shmmgr::shmget): Use the new segment_t::is_deleted method. (server_shmmgr::server_shmmgr): Initialise the new _shm_atts field. (server_shmmgr::delete_segment): Remove the CloseHandle code, as this is now done in the segment_t destructor. (client_request_shm::serve): Look up the client's process object and pass to the server_shmmgr::shmat and server_shmmgr::shmdt methods rather than passing the cache, winpid and cygpid. * cygserver_process.h: Add a cygpid to the process object to make it more useful and then pass process objects rather than winpids where possible. (cleanup_routine::cleanup): Change argument to be a pointer to a process object. (class process): Re-order fields for no discernible reason. (process::_cygpid): New field. (process::process): Add a cygpid argument. (process::winpid): New method. (process::cygpid): Ditto. (process::add): Make public, as it always should have been. (process_cache::process): Add a cygpid argument. * cygserver_process.cc (process::process): Add a cygpid argument and use it to initialise the `_cygpid' field. Re-order initialisers to match new field order. (process::cleanup): Pass `this' rather than just the winpid to cleanup_routine::cleanup. (process_cache::process): Add a cygpid argument and pass it to the process object constructor. * include/sys/shm.h (shmatt_t): Make unsigned as per SUSv3. (shm_info::shm_atts): New field. 2002-07-11 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_shm.cc (class server_shmmgr::segment_t): Add `_' prefix to the names of all fields. 2002-07-10 Conrad Scott <conrad.scott@dsl.pipex.com> * msg.cc: New file of stub functions, no functionality. * sem.cc: Ditto. * shm.cc (client_shmmgr::shmctl): Add support for an out shm_info buffer for the SHM_INFO command. (client_shmmgr::shmget): Use %X to print keys. * include/sys/ipc.h: Comment all fields and values. (IPC_PRIVATE): Change to be non-negative. * include/sys/msg.h: New file with SUSv3 and ipcs(8) interfaces. * include/sys/sem.h: Ditto. * include/sys/shm.h: Comment all fields and values. (struct shm_info): New struct. * cygserver_shm.h (client_request_shm::shminfo): Rename. (client_request_shm::shm_info): New method. (client_request_shm::_parameters.out.hFileMap): Move into union. (client_request_shm::_parameters.out.shminfo): Rename. (client_request_shm::_parameters.out.shm_info): New field. * cygserver_shm.cc (server_shmmgr::_shm_ids): Rename. (server_shmmgr::_shm_tot): New field. (server_shmmgr::shmctl): Rename `out_shminfo' argument. Add `out_shm_info' argument. Fill in the `out_shm_info' argument in the SHM_INFO command. (server_shmmgr::shmget): Check `shmflg' against the mode of existing segments as per Stevens 1990, p. 123. (server_shmmgr::server_shmmgr): Initialise the new `_shm_tot' field. (server_shmmgr::new_segment): Set ENOMEM if CreateFileMapping fails. Pass `size' to new_segment. (server_shmmgr::new_segment): Add size argument and use it to check against and update the new `_shm_tot' field. (server_shmmgr::delete_segment): Update the new `_shm_tot' field. * Makefile.in (DLL_OFILES): Add new DLL object files. 2002-07-09 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_transport_pipes.cc: The main change is to make the client try harder to connect to the server if it's previously connected, and so has good grounds for believing that the server is running. (MAX_WAIT_NAMED_PIPE_RETRY): Change to be an enumerator. (WAIT_NAMED_PIPE_TIMEOUT): Ditto. (transport_layer_pipes::accept): Use interlocked operators on `pipe_instance'. (transport_layer_pipes::close): Rearrange so that FlushFileBuffers and DisconnectNamedPipe are only called for accepted endpoints. Use interlocked operators on `pipe_instance'. (transport_layer_pipes::read): Use set_errno where required. (transport_layer_pipes::write): Ditto. (transport_layer_pipes::connect): Add local static variable `assume_cygserver'. Set it if a connection is made to cygserver, clear it if a connection is not made even after retrying. If set, ignore all errors from CreateFile and retry the connection. Catch the situation where WaitNamedPipe fails to wait [sic] and add a `Sleep (0)' so that the server gets a chance to run. 2002-07-03 Conrad Scott <conrad.scott@dsl.pipex.com> * dcrt0.cc: Only check for cygserver if and when required. (dll_crt0_1): Remove call to `cygserver_init ()'. * fhandler_tty.cc (fhandler_tty_slave::open): Change the cygserver logic to allow for the fact that `cygserver_init ()' may not yet have been called. (fhandler_tty_slave::cygserver_attach_tty): Tweak the cygserver request logic to conform to the practice elsewhere in the code. * tty.cc (tty::common_init): Add an explicit call to `cygserver_init ()' if it hasn't already been called. * include/cygwin/cygserver.h (CYGSERVER_UNAVAIL): Rename from `CYGSERVER_DEAD'. (client_request_get_version::check_version): Make available in cygserver as well the DLL. (check_cygserver_available): Ditto. Remove `check_version_too' argument. (cygserver_init): Ditto. And likewise. * cygserver_client.cc (client_request_get_version::check_version): Make available in cygserver as well the DLL. (client_request::make_request): This may now be called without `cygserver_init ()' having been called first. Detect this and call it as required. Add tracing. (check_cygserver_available): Make available in cygserver as well the DLL. Remove `check_version_too' argument and always check the version information. And since this is called from within `cygserver_init ()', force `cygserver_running' before calling `client_request::make_request ()'. (cygserver_init): Make available in cygserver as well the DLL. Remove `check_version_too' argument. 2002-07-03 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_shm.cc: Implement the ipcs(8) interfaces, IPC_INFO, SHM_STAT and SHM_INFO. (server_shmmgr::segment_t::sequence): New static field. (server_shmmgr::segment_t::key): Remove field, use the new ds.shm_perm.key field instead. (server_shmmgr::segment_t::shmid): Remove field. (server_shmmgr::segment_t::intid): New field. (server_shmmgr::segment_t::segment_t): Use the `key' argument to initialise `ds.shm_perm.key'. Change from using `shmid' to `intid'. (server_shmmgr::_shmseg_cnt): Renamed from `_shmid_cnt'. (server_shmmgr::_intid_max): Renamed from `_shmid_max. (server_shmmgr::shmat): Move the out arguments to the start of the argument list. Rename the `pid' argument as `cygpid'. Add tracing. Pass an intid to `find ()', not a shmid. (server_shmmgr::shmctl): Add separate out arguments. Rename the `pid' argument as `cygpid'. Add support for the ipcs(8) interfaces. Add tracing. Pass an intid to `find ()', not a shmid. (server_shmmgr::shmdt): Rename the `pid' argument as `cygpid'. Add tracing. Pass an intid to `find ()', not a shmid. (server_shmmgr::shmget): Add a separate out arguments. Rename the `pid' argument as `cygpid'. Add tracing. (server_shmmgr::server_shmmgr): Update for new field names. (server_shmmgr::find_by_key): Update for the new `ds.shm_perm.key' field. (server_shmmgr::find): Update to use the new `segment_t::intid' field. (server_shmmgr::new_segment): Rename the `pid' argument as `cygpid'. Check that the requested size is within bounds. Handle new error result from `new_segment (key, HANDLE)'. (server_shmmgr::new_segment): Work with intids, not shmids. Check that the new intid is within bounds. Update for new field names. (server_shmmgr::delete_segment): Pass an intid to `find ()', not a shmid. Update for new field names. (client_request_shm::serve): Check that the incoming message length is the size of the `_parameters.in' struct, not of the whole in/out parameter union. Likewise, set the outgoing message length to the size of the `_parameters.out' struct. Update for the new server_shmmgr interfaces. * include/sys/ipc.h (ipc_perm::key): New field. * include/sys/shm.h (SHM_INFO): New constant. * cygserver_ipc.h (IPCMNI): New constant. (ipc_int2ext): Add `sequence' argument and munge this into the external ipc id. (ipc_ext2int_subsys): Unmunge the sequence number from the external ipc id. (ipc_ext2int): Ditto. (ipc_inc_id): Remove. (ipc_dec_id): Remove. * cygserver_shm.h (SHMMAX): New constant. (SHMMIN): Ditto. (SHMMNI): Ditto. (SHMSEG): Ditto. (SHMALL): Ditto. (client_request_shm::_parameters): Re-arrange as a union of two separate structs, one for in arguments, the other for out. (client_request_shm::shmid): Update for the new parameter layout. (client_request_shm::ds): Ditto. (client_request_shm::info): New method. * shm.cc (client_shmmgr::_shmat_cnt): New static field. (client_shmmgr::shmat): Add locking. Add tracing. (client_shmmgr::shmctl): Update for ipcs(8) commands. Add tracing. Add more argument checking. (client_shmmgr::shmdt): Add locking. Add tracing. Update the new `_shmat_cnt' field. (client_shmmgr::shmget): Add tracing. (client_shmmgr::fixup_shms_after_fork): Add tracing. Add consistency checking. (client_shmmgr::attach): Add more tracing. (client_shmmgr::new_segment): Update the new `_shmat_cnt' field. (client_request_shm::client_request_shm): Update for the new parameter layout. Set the outgoing message length to the size of the `_parameters.in' struct, not of the whole in/out parameter union. 2002-07-02 Conrad Scott <conrad.scott@dsl.pipex.com> * shm.cc: Remove the use of a static client_shmmgr object. (client_shmmgr::_instance): New static variable. (client_shmmgr::instance): Allocate a new shmmgr on the heap, rather than using a local static object. 2002-07-01 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_transport.cc (create_server_transport): Fix cut-and-paste error. 2002-06-30 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_client.cc (client_request::handle_request): Don't bother with the client request activity marker when compiled with debugging output. 2002-06-30 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_transport_pipes.cc (MAX_WAIT_NAMED_PIPE_RETRY): New constant. (WAIT_NAMED_PIPE_TIMEOUT): Ditto. (transport_layer_pipes::close): The `pipe' field is now either NULL or a valid handle, and it should never have the value `INVALID_HANDLE_VALUE'. (transport_layer_pipes::read): Ditto. (transport_layer_pipes::write): Ditto. (transport_layer_pipes::connect): Ditto. (transport_layer_pipes::impersonate_client): Ditto. (transport_layer_pipes::connect): Ditto. New, but still bogus, retry logic. 2002-06-30 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_shm.cc (server_shmmgr::server_shmmgr): All fields have to be initialized now that the singleton is no longer static. 2002-06-30 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_shm.cc (server_shmmgr::_instance): New static field. (server_shmmgr::_instance_once): Ditto. (server_shmmgr::initialise_instance): New static method. (server_shmmgr::instance): Use a pthread_once_t rather than relying on a local static variable. 2002-06-30 Conrad Scott <conrad.scott@dsl.pipex.com> * woutsup.h: Remove all uses of the C++ new and delete operators throughout cygserver until they are fully thread-safe. (safe_new0): New macro to replace the C++ new operator. (safe_new): Ditto. (safe_delete): New macro to replace the C++ delete operator. * cygserver_client.cc (client_request::handle_request): Replace all uses of the C++ new and delete operators with the new macros from "woutsup.h". (client_request::make_request): Ditto. * cygserver_process.cc (~process_cleanup): Ditto. (process::cleanup): Ditto. (process_cache::process): Ditto. (process_cache::check_and_remove_process): Ditto. * cygserver_shm.cc (server_shmmgr::new_segment): Ditto. (server_shmmgr::delete_segment): Ditto. * cygserver_transport.cc (create_server_transport): Ditto. * cygserver_transport_pipes.cc (transport_layer_pipes::accept): Ditto. * cygserver_transport_sockets.cc (transport_layer_sockets::accept): Ditto. * threaded_queue.cc (~threaded_queue): Ditto. (threaded_queue::worker_loop): Ditto. (threaded_queue::stop): Replace sleep(3) with win32 Sleep. * cygserver.cc (~server_request): Replace all uses of the C++ new and delete operators with the new macros from "woutsup.h". (server_submission_loop::request_loop): Ditto. (main): Ditto. Replace sleep(3) with win32 Sleep. Replace iostreams with FILEs. (print_usage): Replace iostreams with FILEs. (print_version): Ditto. 2002-06-30 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_transport_sockets.cc (transport_layer_sockets::accept): Rename local variable `accept_fd' to avoid shadowing the `fd' field. 2002-06-29 Conrad Scott <conrad.scott@dsl.pipex.com> * cygwin_ipc.h: Moved (back) to "include/sys/ipc.h". * cygwin_shm.h: Moved (back) to "include/sys/shm.h". * include/sys/ipc.h: New file. * include/sys/shm.h: New file. * cygserver_shm.h: Update for new header file locations. * ipc.cc: Ditto. 2002-06-28 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_client.cc (client_request::make_request): Comment out a verbose tracing statement. * cygserver_process.cc (process_cache::sync_wait_array): Fix broken assert. * include/cygwin/cygserver.h (class client_request): Remove excess use of `class' qualifier in declarations. (class client_request_get_version): Ditto. (class client_request_shutdown): Ditto. (class client_request_attach_tty): Ditto. 2002-06-28 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_ipc.h: New file. * cygserver_shm.h: Re-written from scratch. * cygserver_shm.cc: Ditto. * shm.cc: Ditto. 2002-06-28 Conrad Scott <conrad.scott@dsl.pipex.com> * threaded_queue.h (class queue_request): Re-write. (threaded_queue_thread_function): Remove. (class queue_process_param): Remove. (class threaded_queue): Re-write. (class queue_submission_loop): New version of the old `queue_process_param' class. (TInterlockedExchangePointer): New templated function. (TInterlockedCompareExchangePointer): Ditto. * threaded_queue.cc (worker_function): Remove. (class threaded_queue): Re-write. (class queue_process_param): Remove. (class queue_submission_loop): New version of the old `queue_process_param' class. * include/cygwin/cygserver_process.h (process_cleanup): Re-write. (class process_process_param): Remove. (class cleanup_routine): Re-write. (class process): Re-write. (class process_cache): Re-write. * cygserver_process.cc (process_cleanup): Re-write. (class process_process_param): Remove. (class cleanup_routine): Re-write. (class process): Re-write. (class process_cache): Re-write. * cygserver.cc (request_count): Remove unused variable. (class server_request): Move methods inline. (class server_process_param): Remove. (class server_request_queue): Remove. (request_queue): Move into `main ()' and change type to `threaded_queue'. (request_loop): Remove. (class server_submission_loop): New version of the old `server_process_param' class. (shutdown_server): New variable. (client_request_shutdown::serve): Set `shutdown_server' to trigger shutdown. (handle_signal): Ditto. (main): Install signal handler for SIGINT rather than SIGQUIT. Use new interfaces for the `request_queue' and the `cache'. Create a `server_submission_loop' and add to the `request_queue'. Add check for the `shutdown_server' variable to the main loop. * cygserver_shm.cc (client_request_shm::serve): Release the process object after use. 2002-06-27 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_client.cc (client_request::handle_request): Correct tracing statement. * cygserver_transport_pipes.cc: Remove local definition of FILE_FLAG_FIRST_PIPE_INSTANCE constant. * cygwin_ipc.h: Update copyright notice. * cygwin_shm.h: Ditto. * woutsup.h: Add definition of _WIN32_WINNT. 2002-06-24 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_client (client_request::make_request): Replace my inappropriate use of set_errno () with error_code () throughout. 2002-06-24 Conrad Scott <conrad.scott@dsl.pipex.com> * include/cygwin/cygserver.h: Add forward declarations of class transport_layer_base and class process_cache to reduce dependencies between header files. * include/cygwin/cygserver_process.h: Add include of "threaded_queue.h". * cygserver.cc: Remove unnecessary cygserver header files. * cygserver_client.cc: Ditto. * cygserver_process.cc: Ditto. * cygserver_shm.cc: Ditto. * cygserver_shm.h: Ditto. * cygserver_transport_pipes.cc: Ditto. * dcrt0.cc: Ditto. * fhandler_tty.cc: Ditto. * tty.cc: Ditto. 2002-06-24 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_shm.h: Replace <sys/shm.h> with "cygwin_shm.h" after merge from HEAD. * cygwin_ipc.h: Update with changes to include/sys/ipc.h lost in merge from HEAD. * cygwin_shm.h: Ditto. 2002-06-21 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver.cc: The tests for a duplicate server instance are now the responsibility of the transport layer. (request_loop): Use new `recoverable' flag in call to `cygserver_transport::accept ()' and shutdown on an unrecoverable error. (main): Never call `cygserver_init ()'. Fake `cygserver_running' just for sending a shutdown request. * cygserver_client.cc (client_request::send): Comment out message-size tracing statements as verbose. (client_request::handle): Ditto. (client_request_get_version::check_version): #ifdef as DLL-only. (check_cygserver_available): Ditto. (cygserver_init): Ditto. * include/cygwin/cygserver.h (client_request_get_version::check_version): #ifdef as DLL-only. (check_cygserver_available): Ditto. (cygserver_init): Ditto. * include/cygwin/cygserver_transport.h (transport_layer_base::impersonate_client): #ifdef as cygserver-only. (transport_layer_base::revert_to_self): Ditto. (transport_layer_base::listen): Ditto. (transport_layer_base::accept): Ditto. Add a `recoverable' out flag for error handling. * include/cygwin/cygserver_transport_sockets.h: Ditto. * include/cygwin/cygserver_transport_pipes.h: Ditto. (transport_layer_pipes): Change type of the `pipe_name' field. Remove the `inited' field, as unnecessary. Add new `is_accepted_endpoint' field. * include/cygwin/cygserver_transport.cc (transport_layer_base::impersonate_client): #ifdef as cygserver-only. (transport_layer_base::revert_to_self): Ditto. * include/cygwin/cygserver_transport_sockets.cc (transport_layer_sockets::listen): #ifdef as cygserver-only. (transport_layer_sockets::accept): #ifdef as cygserver-only. Analyse any errno from `accept ()' and set `recoverable' as appropriate. * cygserver_transport_pipes.cc: Add local #define of `FILE_FLAG_FIRST_PIPE_INSTANCE'. (pipe_instance_lock_once): New variable. (pipe_instance_lock): Ditto. (pipe_instance): Ditto. (initialise_pipe_instance_lock): New function. (transport_layer_pipes::transport_layer_pipes): Change initialization of `pipe_name'. Initialize `is_accepted_endpoint' as appropriate. Remove use of `inited'. (transport_layer_pipes::impersonate_client): #ifdef as cygserver-only. (transport_layer_pipes::revert_to_self): Ditto. (transport_layer_pipes::listen): Ditto. (transport_layer_pipes::accept): Ditto. Keep track of how often many named pipes have been created, in the `pipe_instance' variable, and pass the `FILE_FLAG_FIRST_PIPE_INSTANCE' flag on the open of the first instance. Analyse the error code from `CreateNamedPipe ()' and set the `recoverable' flag as appropriate. (transport_layer_pipes::close): Update the `pipe_instance' count. 2002-06-18 Conrad Scott <conrad.scott@dsl.pipex.com> * woutsup.h (cygserver_running): Add declaration. (api_fatal): Eliminate. * include/cygwin/cygserver.h (client_request_get_version::check_version): Change return type to bool. (check_cygserver_available): New function. (cygserver_init): Add check_version_too argument. * cygserver_client.cc (allow_daemon): Make a bool. (client_request_get_version::make_request): See errno on error. Remove special case for CYGSERVER_REQUEST_GET_VERSION; this is now handled in cygserver_init(). (client_request_get_version::check_version): Use syscall_printf() instead of api_fatal(). Return true if cygserver version is compatible. (check_cygserver_available): New function; code moved here from cygserver_init(). (cygserver_init): Move some code into check_cygserver_available(). * cygserver.cc (__set_errno): Copy from debug.cc so that set_errno() can be used when __OUTSIDE_CYGWIN__. (main): Call cygserver_init() to set up cygserver_running and add checks against this to (try and) prevent multiple copies of cygserver running simultaneously. Remember to delete all transport connections so that (one day) the transport classes can tidy up on cygserver shutdown. 2002-06-17 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver.cc (main): Adjust tracing output for a cleaner display when compiled without --enable-debugging. * threaded_queue.cc (threaded_queue::cleanup): Ditto. (queue_process_param::stop): Ditto. * include/cygwin/cygserver.h (client_request::make_request): Make non-virtual. (client_request::send): Make virtual and protected, not private. (client_request_attach_tty::send): New virtual method. * cygserver_client.cc: Use the `msglen()' accessor rather than `_header.msglen' throughout. (client_request_attach_tty::send): New method. (client_request::make_request): Remove the explicit close of `transport' as it is closed on deletion. 2002-06-17 Conrad Scott <conrad.scott@dsl.pipex.com> * include/cygwin/cygserver.h: Change the client_request classes to give greater encapsulation and to allow variable length requests and replies. (enum cygserver_request_code): Now client_request::request_code_t. (class request_header): Now client_request::header_t. Make a union of the request_code and the error_code. The `cb' field, which was the buffer length, is now the `size_t msglen' field. (struct request_get_version): Now client_request_get_version::request_get_version. (struct request_shutdown): Remove unused type. (struct request_attach_tty): Now client_request_attach_tty::request_attach_tty. (client_request::_buf): Make field const. (client_request::_buflen): New const private field. (client_request::request_code): New accessor. (client_request::error_code): Ditto. (client_request::msglen): Ditto. (client_request::handle_request): New static method. (client_request::make_request): New virtual method. (client_request::handle): New method. (client_request::send): Make private. (client_request_get_version::check_version): New method. (client_request_get_version::serve): Make private. (client_request_get_version::version): Ditto. (client_request_shutdown::serve): Ditto. (client_request_attach_tty::req): Ditto. (client_request_attach_tty::serve): Ditto. (client_request_attach_tty::from_master): Make method const. (client_request_attach_tty::from_master): Ditto. * cygserver_client.cc (client_request_get_version::client_request_get_version): Track changes to the client_request classes. (client_request_attach_tty::client_request_attach_tty): Ditto. (client_request_get_version::check_version): New method to encapsulate code from cygserver_init(). (client_request_shutdown::client_request_shutdown): Move into "cygserver.cc". (client_request::send): Track changes to the client_request classes. Add more error checking. (client_request::handle_request): New static method containing the first half of the old server_request::process() code. (client_request::make_request): New method to replace the old cygserver_request() function. (client_request::handle): New method containing the second half of the old server_request::process() code. (cygserver_init): Track changes to the client_request classes. In particular, some code moved into the client_request_get_version::check_version() method. * cygserver.cc (client_request_attach_tty::serve): Track changes to the client_request classes. In particular, only return a reply body if some handles are successfully duplicated for the client. And remove goto's. (client_request_get_version::serve): Track changes to the client_request classes. (client_request_shutdown::serve): Ditto. (class client_request_invalid): Dead, and so young too. (server_request::request_buffer): Remove unnecessary field. (client_request_shutdown::client_request_shutdown): Moved here from "cygserver_client.cc". (server_request::process): Implementation moved into the new client_request::handle_request() and client_request::handle() methods. * cygserver_shm.h (class client_request_shm): Put client- and server-specific interfaces inside #ifdef/#ifndef __INSIDE_CYGWIN__ guards. (client_request_shm::serve): Make private. * cygserver_shm.cc (client_request_shm::client_request_shm): Track changes to the client_request classes. (client_request_shm::serve): Ditto * shm.cc (client_request_shm::client_request_shm): Ditto. Use alloc_sd() rather than set_security_attribute() to get access to the SECURITY_DESCRIPTOR length, so that we can use it to set the request body length. (shmat): Track changes to the client_request classes. In particular, allocate client_request objects on the stack rather than on the heap, and use the client_request::make_request() method rather than the old cygserver_request() function. (shmdt): Ditto. (shmctl): Ditto. (shmget): Ditto. * fhandler_tty.cc (fhandler_tty_slave::cygserver_attach_tty): Ditto. 2002-06-17 Conrad Scott <conrad.scott@dsl.pipex.com> * include/cygwin/cygserver_transport.h (cygserver_transport::read): Change buffer type to void *. (cygserver_transport::write): Ditto. * include/cygwin/cygserver_transport_sockets.h (cygserver_transport_sockets::read): Ditto. (cygserver_transport_sockets::write): Ditto. * include/cygwin/cygserver_transport_pipes.h (cygserver_transport_pipes::read): Ditto. (cygserver_transport_pipes::write): Ditto. * cygserver_transport_sockets.cc (cygserver_transport_sockets::read): Ditto. (cygserver_transport_sockets::write): Ditto. * cygserver_transport_pipes.cc (cygserver_transport_pipes::read): Ditto. Set errno on error, to match behaviour of cygserver_transport_sockets class. (cygserver_transport_pipes::write): Ditto. 2002-06-16 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver.cc (version): New static variable. (server_request_queue::add_connection): Remove my gratuitous use of studly caps. (setup_privileges): Declare static. (handle_signal): Ditto. (longopts): Make a local variable of main(). (opts): Ditto. (print_usage): New function. (print_version): Ditto (tip of the hat to Joshua Daniel Franklin for inspiration here). (main): More argument checking. Add --help and --version options. 2002-06-16 Conrad Scott <conrad.scott@dsl.pipex.com> * include/cygwin/cygserver.h (client_request::serve): Make pure virtual. * cygserver.cc (client_request::serve): Remove definition of pure virtual method. (class client_request_invalid): New class. (server_request::process): Use new client_request_invalid class. And remove goto's. 2002-06-16 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver.cc (class server_request): Add virtual destructor. (server_request_queue::addConnection): New method to replace bad virtual add() method. (request_loop): Replace call to queue->add() with call to queue->addConnection(). (server_request::server_request): Use field initialization. (server_request::~server_request): New virtual destructor. (server_request::process): Remove close and delete of transport_layer_base object. It is deleted by the server_request's own destructor and closed by its own destructor. * include/cygwin/cygserver.h (client_request::operator request_header): Remove unused method. * cygserver_client.cc: Ditto. * include/cygwin/cygserver_process.h (class cleanup_routine): Add virtual destructor. (cleanup_routine::cleanup): Make pure virtual. (class process_cache): Make destructor non-virtual. (process_cache::add): Ditto. * cygserver_process.cc (cleanup_routine::~cleanup_routine): New virtual destructor. * include/cygwin/cygserver_transport.h (class transport_layer_base): Add virtual destructor. * cygserver_transport.cc (transport_layer_base::~transport_layer_base): New virtual destructor. * include/cygwin/cygserver_transport_pipes.h (class transport_layer_pipes): Add virtual destructor. * cygserver_transport_pipes.cc (transport_layer_pipes::~transport_layer_pipes): New virtual destructor. (transport_layer_pipes::close): Null out handle after closing. * include/cygwin/cygserver_transport_sockets.h (class transport_layer_sockets): Add virtual destructor. * cygserver_transport_sockets.cc (transport_layer_sockets::~transport_layer_sockets): New virtual destructor. (transport_layer_sockets::close): Null out fd after closing. * threaded_queue.h (class queue_request): Add virtual destructor. (queue_request::process): Make pure virtual. * threaded_queue.cc (~queue_request): New virtual destructor. (queue_request::process): Remove definition of pure virtual method. 2002-06-16 Conrad Scott <conrad.scott@dsl.pipex.com> * include/cygwin/cygserver.h (client_request::send): Make non-virtual. (class client_request_attach_tty): Put client- and server-specific interfaces inside #ifdef/#ifndef __INSIDE_CYGWIN__ guards. * cygserver_client.cc: Ditto. (cygserver_init): Fix error handling. 2002-06-16 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver.cc: Throughout the code, check and correct level of the XXX_printf() functions used. Comment out several of the debug_printf() calls with "// verbose:". Reformat and correct typos of some of the XXX_printf() formats. * cygserver_process.cc: Ditto. * cygserver_shm.cc: Ditto. * cygserver_transport_pipes.cc: Ditto. * cygserver_transport_sockets.cc: Ditto. * shm.cc (hi_ulong): New function to allow printing of a 64-bit key with current small_printf implementation. (lo_ulong): Ditto. (client_request_shm::client_request_shm): Use hi_ulong() and lo_ulong() in call to debug_printf(). 2002-06-16 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver_shm.cc: Remove #define __INSIDE_CYGWIN__ from around <sys/shm.h> as it no longer contains any internal code. 2002-06-16 Conrad Scott <conrad.scott@dsl.pipex.com> * include/sys/ipc.h (IPC_PRIVATE): Add cast to key_t. (IPC_INFO): New flag for ipcs(8). (IPC_RMID IPC_SET IPC_STAT): Renumber. * include/sys/shm.h (SHM_RDONLY SHM_RND): Renumber with distinct values [sic]. (class _shmattach): Internal type moved to "cygserver_shm.h". (class shmnode): Ditto. (class shmid_ds): Ditto. (struct shmid_ds): Add spare fields. (struct shminfo): New type for IPC_INFO interface. * cygserver_shm.h: Remove obsolete #if 0 ... #endif block. (class shm_cleanup): Remove unused class. (struct _shmattach): Internal type moved from <sys/shm.h>. (struct shmnode): Ditto. (struct int_shmid_ds): Ditto. Renamed to avoid name clash with public interface struct shmid_ds. Use the shmid_bs structure as a field. * cygserver_shm.cc: Remove obsolete #if 0 ... #endif block. (client_request_shm::serve): Update for redefinition of int_shmid_ds structure. * shm.cc (build_inprocess_shmds): Ditto. (fixup_shms_after_fork): Ditto. (shmctl): Ditto. (shmget): Ditto. Remove obsolete #if 0 ... #endif code. 2002-06-16 Conrad Scott <conrad.scott@dsl.pipex.com> * include/cygwin/cygserver_transport.h (transport_layer_base::transport_layer_base): Remove since it is now redundant. (transport_layer_base::listen): Make a pure virtual method. (transport_layer_base::accept): Ditto. (transport_layer_base::close): Ditto. (transport_layer_base::read): Ditto. (transport_layer_base::write): Ditto. (transport_layer_base::connect): Ditto. * cygserver_transport.cc (transport_layer_base::transport_layer_base): Remove since it is now redundant. (transport_layer_base::listen): Remove since it is now a pure virtual method. (transport_layer_base::accept): Ditto. (transport_layer_base::close): Ditto. (transport_layer_base::read): Ditto. (transport_layer_base::write): Ditto. (transport_layer_base::connect): Ditto. 2002-06-16 Conrad Scott <conrad.scott@dsl.pipex.com> * cygserver.cc (check_and_dup_handle): Only use security code if running on NT, i.e. if wincap.has_security(). (client_request_attach_tty::serve): Add check for has_security(). * cygserver_process.cc (process_cache::process): Use DWORD winpid throughout to avoid win32 vs. cygwin pid confusion. (process::process): Ditto. * cygserver_shm.cc (client_request_shm::serve): Only use security code if running on NT, i.e. if wincap.has_security(). * cygserver_shm.h (client_request_shm::parameters.in): Replace the ambiguous pid field with cygpid and winpid fields. (client_request_shm::client_request_shm): Reduce to only two client-side constructors: one for SHM_CREATE, another for all the other requests. * shm.cc (client_request_shm::client_request_shm): Ditto. Initialize cygpid and winpid fields here. On NT initialize sd_buf here using set_security_attribute() to make use of the euid and egid. (shmat): Use new client_request_shm constructor. (shmdt): Ditto. (shmctl): Ditto. (shmget): Ditto. Remove security code, now performed in the relevant client_request_shm constructor. * include/cygwin/cygserver_process.h: (class cleanup_routine): Change winpid type to DWORD. (class process): Ditto. 2002-06-15 Conrad Scott <conrad.scott@dsl.pipex.com> * woutsup.h: New file. * cygserver.cc: Use "woutsup.h" and new XXX_printf macros. (getfunc): New function, copied verbatim from "strace.cc". (__cygserver__printf): New function. * cygserver_client.cc: Use "woutsup.h" and new XXX_printf macros. * cygserver_process.cc: Ditto. * cygserver_shm.cc: Ditto. * cygserver_transport.cc: Ditto. * cygserver_transport_pipes.cc: Ditto. * cygserver_transport_sockets.cc: Ditto. * threaded_queue.cc: Ditto. * shm.cc: Remove trailing \n from XXX_printf format strings. * Makefile.in: Remove special __OUTSIDE_CYGWIN__ case for cygserver_shm.cc.
2002-09-22* init.cc (dll_entry): Temporarily disable thread detach code.Christopher Faylor1-0/+4
2002-09-22* fhandler.cc (fhandler_base::dup): Don't set handle on failure. Caller hasChristopher Faylor43-235/+250
already taken care of that. * fhandler_console.cc (fhandler_console::open): Initialize handles to NULL. (fhandler_console::close): Ditto. GNUify non-GNU formatted functions calls throughout.
2002-09-22whitespaceChristopher Faylor1-4/+4
2002-09-21 * cygwin_ipc.h: Move to "include/cygwin/ipc.h".Conrad Scott7-7/+17
* cygwin_shm.h: Move to "include/cygwin/shm.h". * include/cygwin/ipc.h: New file. * include/cygwin/shm.h: New file. * ipc.c:c Update <cygwin/ipc.h> include. * cygserver_shm.cc: Update <cygwin/shm.h> include. * shm.cc: Ditto.
2002-09-212002-09-21 Robert Collins <rbtcollins@hotmail.com>Robert Collins4-68/+78
* pthread.cc: Use class::call for converted pthread and semaphore calls. * thread.cc: Convert various __pthread_call and __sem_call to pthread::call and sem::call throughout. * pthread.h (__pthread_cancel): Convert to pthread::cancel. (__pthread_join): Convert to pthread::join. (__pthread_detach): Convert to pthread::detach. (__pthread_create): Convert to pthread::create. (__pthread_once): Convert to pthread::once. (__pthread_atfork): Convert to pthread::atfork. (__pthread_suspend): Convert to pthread::suspend. (__pthread_continue): Convert to pthread::resume. (__sem_init): Convert to semaphore::init. (__sem_destroy): Convert to semaphore::destroy. (__sem_wait): Convert to semaphore::wait. (__sem_trywait): Convert to semaphore::trywait. (__sem_post): Convert to semaphore::post.
2002-09-212002-09-21 Robert Collins <rbtcollins@hotmail.com>Robert Collins3-148/+107
* thread.cc: Finish the removal of the separate pthread_key destructor list. Remove all pthread_key_destructor and pthread_key_destructor_list references throughout. (pthread::exit): Call the new pthread_key interface to activate destructors. (pthread_key::keys): Change into a list. (pthread_key::saveAKey): New method, used via forEach. (pthread_key::restoreAKey): Ditto. (pthread_key::destroyAKey): Ditto. (pthread_key::fixup_before_fork): Use the List::forEach functionality. (pthread_key::fixup_after_fork): Ditto. (pthread_key::runAllDestructors): New method implementation. (pthread_key::pthread_key): Use List::Insert rather than custom list code. (pthread_key::~pthread_key): Use List::Remove for the same reason. * thread.h: Remove all pthread_key_destructor and pthread_key_destructor_list references throughout. (List): Move the interface above pthread_key in the header. Use atomic operations during insert and delete. (List::forEach): A generic interface for doing something on each node. (pthread_key::runAllDestructors): New method, run all destructors. (pthread_key::fork_buf): Make private. (pthread_key::run_destructor): Ditto. (pthread_key::saveAKey): New method for clearer source. (pthread_key::restoreAKey): Ditto. (pthread_key::destroyAKey): Ditto. (MTinterface::destructors): Remove.
2002-09-212002-09-21 Robert Collins <rbtcollins@hotmail.com>Robert Collins3-33/+76
* thread.cc: Partial refactoring of pthread_key destructor handling. Loosely based on Thomas Pfaff's work. (pthread_key_destructor_list::Insert): Remove. (pthread_key_destructor_list::Pop): Remove. (pthread_key_destructor_list::IterateNull): Call the key's run_destructor method. (pthread_key::pthread_key): Initialize new member. (pthread_key::get): Mark as const for correctness. (pthread_key::run_destructor): Implement. * thread.h (pthread_key::get): Mark as const for correctness. (pthread_key::run_destructor): Declare. (List): New template class that implements a generic list. (pthread_key_destructor_list): Inherit from List, and remove now duplicate functions.
2002-09-202002-09-21 Robert Collins <rbtcollins@hotmail.com>Robert Collins3-47/+134
* thread.cc: Change verifyable_object_isvalid calls with PTHREAD_CONDATTR_MAGIC, PTHREAD_MUTEXATTR_MAGIC, PTHREAD_COND_MAGIC, SEM_MAGIC to objecttype::isGoodObject() calls throughout. (pthread_condattr::isGoodObject): Implement. (pthread_mutex::isGoodInitializer): Implement. (pthread_mutex::isGoodInitializerOrObject): Minor bugfix in the check for verifyable_object_isvalid result. (pthread_mutexattr::isGoodObject): Implement. (pthread_cond::isGoodObject): Ditto. (pthread_cond::isGoodInitializer): Ditto. (pthread_cond::isGoodInitializerOrObject): Ditto. (semaphore::isGoodObject): Ditto. * thread.h (pthread_mutex::isGoodInitializer): Declare. (pthread_condattr::isGoodObject): Ditto. (pthread_cond::isGoodObject): Const correctness. (pthread_cond::isGoodInitializer): Declare. (pthread_cond::isGoodInitializerOrObject): Ditto. (semaphore::isGoodObject): Const correctness.
2002-09-202002-09-21 Robert Collins <rbtcollins@hotmail.com>Robert Collins3-61/+99
* thread.cc: Change verifyable_object_isvalid calls with PTHREAD_MUTEX_MAGIC and PTHREAD_KEY_MAGIC and PTHREAD_ATTR_MAGIC to ::isGoodObject() calls throughout. (MTinterface::Init): Remove dead code. (pthread_attr::isGoodObject): Implement. (pthread_key::isGoodObject): Implement. (pthread_mutex::isGoodObject): Implement. (pthread_mutex::isGoodInitializerOrObject): Implement. (pthread::isGoodObject): Update signature. * thread.h (pthread_key::isGoodObject): Declare. (pthread_attr::isGoodObject): Ditto. (pthread_mutex::isGoodObject): Ditto. (pthread_mutex::isGoodInitializerOrObject): Ditto. (pthread::isGoodObject): Change to a const parameter for const correctness. (pthread_mutexattr::isGoodObject): Declare. (pthread_condattr::isGoodObject): Ditto. (pthread_cond::isGoodObject): Ditto. (semaphore::isGoodObject): Ditto.
2002-09-19 * mingwex/math/files.txt: Remove inadvertantly added file.Danny Smith2-1/+4
2002-09-19Cleanup calls to CreateFile throughout.Christopher Faylor11-65/+56
* dcrt0.cc (__api_fatal): Correctly check for failing return from CreateFile. * assert.cc (__assert): Don't check return value from CreateFile for NULL. * fhandler_console.cc (set_console_state_for_spawn): Ditto. * fork.cc (fork_parent): Ditto.
2002-09-19 * include/string.h (_strerror): Move into #ifndefDanny Smith2-1/+7
__STRICT_ANSI__ block.
2002-09-19* cygcheck.cc: Include sys/time.h rather than time.h to avoid a compiler error.Christopher Faylor2-1/+6
2002-09-19* cygthread.cc (cygthread::initialized): Avoid copying on fork or some threadsChristopher Faylor20-112/+153
may not end up in the pool. (cygthread::new): Avoid race when checking for initialized. Add debugging code. * fhandler.cc (fhandler_base::raw_read): Add case for ERROR_INVALID_HANDLE due to Win95 directories. (fhandler_base::open): Handle errors due to Win95 directories. (fhandler_base::close): Add get_nohandle () test. (fhandler_base::set_close_on_exec): Ditto. (fhandler_base::fork_fixup): Ditto. (fhandler_base::lock): Change error code to Posix EINVAL. (fhandler_base::dup): If get_nohandle (), set new value to INVALID_HANDLE_VALUE instead of NULL. * fhandler_disk_file.cc (fhandler_disk_file::fstat): Call fstat_by_name if get_nohandle (). Remove extraneous element from strpbrk. (fhandler_disk_file::open): Remove test for Win95 directory. * fhandler_random.cc (fhandler_dev_random::open): Add set_nohandle (). * fhandler_clipboard.cc (fhandler_dev_clipboard::open): Ditto. * fhandler_zero.cc (fhandler_dev_zero::open): Ditto. (fhandler_dev_zero::close): Delete. * fhandler.h (class fhandler_dev_zero): Ditto.
2002-09-192002-09-18 Eric R. Krause <ekrause_98@users.sourceforge.net>Danny Smith2-0/+5
* include/winuser.h (DS_SHELLFONT): Define.
2002-09-17 * include/time.h (__need_NULL): Define before includingDanny Smith2-0/+6
stddef.h. Thanks to: R�diger Dehmel <de@lmnet.de>.
2002-09-172002-09-17 Daniel Schlyder <daniel@dascdev.net>Danny Smith2-0/+5
* include/winnt.h (VER_SUITE_BLADE): Define.
2002-09-17* cygcheck.cc: Reorder includes to avoid compiler error.Christopher Faylor2-2/+6
2002-09-172002-09-17 Robert Collins <rbtcollins@hotmail.com>Robert Collins2-2/+9
* thread.cc (pthread_key::set): Preserve GetLastError(). Reported by Thomas Pffaf.
2002-09-172002-09-17 Robert Collins <rbtcollins@hotmail.com>Robert Collins4-37/+148
This work inspires by Thomas Pfaff's pthread_fork patch (1). * fork.cc (fork_child): Remove MTinterface fixup call, it's adsorbed by pthread::atforkchild. Rename __pthread_atforkchild to pthread::atforkchild to give access to private members. (fork_parent): Rename __pthread_atforkparent to pthread::atforkparent to give it access to private members. Ditto for __pthread_atforkprepare. * thread.cc: Fix some formatting problems throughout. (MTinterface::fixup_before_fork): Implement. (MTinterface::fixup_after_fork): Fix pthread_keys. (pthread_key::keys): Implement. (pthread_key::fixup_before_fork): Ditto. (pthread_key::fixup_after_fork): Ditto. (pthread_key::pthread_key): Add to pthread_key::keys. (pthread_key::~pthread_key): Remove from pthread_key::keys. (pthread_key::saveKeyToBuffer): Implement. (pthread_key::recreateKeyFromBuffer): Ditto. (pthread::atforkprepare): Prepare all MT classes for fork. (pthread::atforkchild): And fix them up afterwards. * thread.h (pthread_key): Buffer the key value during fork in fork_buf. List the keys needing to be fixed up in a linked list with head pthread_key::keys. (pthread): Move atfork cygwin internal calls into the class. (MTInterface): Provide a fixup_before_fork for objecst that need to save state. (__pthread_atforkprepare): Remove. (__pthread_atforkparent): Remove. (__pthread_atforkchild): Remove.
2002-09-17 * include/shlobj.h (SHGetSpecialFolderPath[AW]): Add _WIN32_IE guard.Danny Smith2-7/+33
Correct prototype for wide version. (SHGetFolderPath): Add comment on shfolder.dll library. (SHGetFolderLocation): Add prototyope for WinME and W2K. (SHGetFolderPathAndSubDir[AW]): Add prototypes for XP.
2002-09-16* init.cc: Cleanup slightly and remove obsolete code.Christopher Faylor5-30/+21
2002-09-162002-09-11 Robert Collins <rbtcollins@hotmail.com>Robert Collins5-66/+298
* init.cc (dll_entry): On thread detach, if the thread hasn't exit()ed, do so. * pthread.cc (pthread_getsequence_np): Remove the __pthread_getsequence_np wrapper. This requires errno.h. * thread.cc (pthread::self): Instantiate a new pthread object when called and none exists. return a NULL object if instantiation fails. (pthread::precreate): Factor out common code. (pthread::postcreate): Ditto. (pthread::create): Ditto. (pthread::exit): Remove the TLS value when we exit to prevent double exits. (MTinterface::Init): Bugfix - don't mark the TLS index as created if one was not allocated. Apply Extract Method to move pthread specific initialisation into pthread. (pthread::initMainThread): Extracted method from MTinterface::Init. (pthread::setTlsSelfPointer): Extracted method from various pthread calls, to make reading those functions easier. (pthread::setThreadIdtoCurrent): Ditto. (pthread::cancel_self): Bring into the .cc file, it's only used within the class. (pthread::getThreadId): Ditto. (pthread::thread_init_wrapper): Apply Extract Method to the TLS setting logic. (pthread::isGoodObject): Extracted method from various pthread wrapper calls, for clarity of reading. (pthread::getsequence_np): Converted from __pthread_getsquence_np. (__pthread_create): Apply Extract Method to the object validation. (__pthread_cancel): Ditto. (__pthread_join): Ditto. (__pthread_detach): Ditto. (__pthread_suspend): Ditto. (__pthread_continue): Ditto. (__pthread_getschedparam): Ditto. (__pthread_getsequence_np): Remove. (__pthread_setschedparam): Apply Extract Method to the object validation. (pthreadNull::getNullpthread): New method, return the pthreadNull object. (pthreadNull::pthreadNull): Private constructor to prevent accidental use. (pthreadNull::~pthreadNull): Prevent compile warnings. (pthreadNull::create): Override pthread behaviour. (pthreadNull::exit): Ditto. (pthreadNull::cancel): Ditto. (pthreadNull::testcancel): Ditto. (pthreadNull::setcancelstate): Ditto. (pthreadNull::setcanceltype): Ditto. (pthreadNull::push_cleanup_handler): Ditto. (pthreadNull::pop_cleanup_handler): Ditto. (pthreadNull::getsequence_np): Ditto. (pthreadNull::_instance): Ditto. * thread.h (pthread): Declare pre- and post-create. Move GetThreadId to private scope and rename to getThreadId. Move setThreadIdtoCurrent to private scope. Make create virtual. Make ~pthread virtual. Declare initMainThread. Declare isGoodObject. Make exit virtual. Make cancel virtual. Make testcancel virtual. Make setcancelstate virtual. Make setcanceltype virtual. Make push_cleanup_handler virtual. Make pop_cleanup_handler virtual. Declare getsequence_np. Declare setTlsSelfPointer. (pthreadNull): New null object class for pthread. (__pthread_getsequence_np): Remove.
2002-09-16 * lib/shell32.def (SHGetFolderPath[AW]): Add comment.Danny Smith3-1/+12
* lib/shfolder.def: New file.
2002-09-162002-09-16 Ranjit Matthew <rmathew@hotmail.com>Danny Smith2-1/+5
* include/stdio.h: Correct comment about directory separator.
2002-09-15Add final newlines to utilsJoshua Daniel Franklin14-13/+41